fix getting element's offsetLeft when it is absolutely positioned

Theadd · May 9, 2015 · c8e1703 · c8e1703
1 parent 70a3600
commit c8e1703
Show file tree

Hide file tree

Showing 9 changed files with 21 additions and 21 deletions.
diff --git a/addons.js b/addons.js
@@ -2017,7 +2017,7 @@ var TabGroup = React.createClass({
 
       var node = this.getDOMNode(),
         tabWidth = node.offsetWidth / this.tabKeys.length,
-        distance = e.pageX - node.offsetLeft,
+        distance = e.pageX - node.getBoundingClientRect().left,
         index = parseInt(distance / tabWidth),
         targetKey = this.tabKeys[index] || false;
 
@@ -2049,7 +2049,7 @@ var TabGroup = React.createClass({
         this._index = false;
         this.handler.setParentOfToken(this.memberId);
       } else {
-        var distance = e.pageX - this.getDOMNode().offsetLeft;
+        var distance = e.pageX - this.getDOMNode().getBoundingClientRect().left;
         nextIndex = parseInt(distance / this.tabWidth);
       }
 
@@ -2085,7 +2085,7 @@ var TabGroup = React.createClass({
     var node = this.getDOMNode(),
       numTabsMod = this.ctx.ownerId == this.memberId ? 0 : 1,
       tabWidth = node.offsetWidth / (this.tabKeys.length + numTabsMod),
-      distance = e.pageX - node.offsetLeft,
+      distance = e.pageX - node.getBoundingClientRect().left,
       index = parseInt(distance / tabWidth);
 
     this.tabWidth = tabWidth;

diff --git a/dist/react-panels-with-addons.js b/dist/react-panels-with-addons.js
@@ -2017,7 +2017,7 @@ var TabGroup = React.createClass({
 
       var node = this.getDOMNode(),
         tabWidth = node.offsetWidth / this.tabKeys.length,
-        distance = e.pageX - node.offsetLeft,
+        distance = e.pageX - node.getBoundingClientRect().left,
         index = parseInt(distance / tabWidth),
         targetKey = this.tabKeys[index] || false;
 
@@ -2049,7 +2049,7 @@ var TabGroup = React.createClass({
         this._index = false;
         this.handler.setParentOfToken(this.memberId);
       } else {
-        var distance = e.pageX - this.getDOMNode().offsetLeft;
+        var distance = e.pageX - this.getDOMNode().getBoundingClientRect().left;
         nextIndex = parseInt(distance / this.tabWidth);
       }
 
@@ -2085,7 +2085,7 @@ var TabGroup = React.createClass({
     var node = this.getDOMNode(),
       numTabsMod = this.ctx.ownerId == this.memberId ? 0 : 1,
       tabWidth = node.offsetWidth / (this.tabKeys.length + numTabsMod),
-      distance = e.pageX - node.offsetLeft,
+      distance = e.pageX - node.getBoundingClientRect().left,
       index = parseInt(distance / tabWidth);
 
     this.tabWidth = tabWidth;

diff --git a/dist/react-panels-with-addons.min.js b/dist/react-panels-with-addons.min.js
diff --git a/dist/react-panels-with-addons.min.js.map b/dist/react-panels-with-addons.min.js.map
diff --git a/dist/react-panels.js b/dist/react-panels.js
@@ -2017,7 +2017,7 @@ var TabGroup = React.createClass({
 
       var node = this.getDOMNode(),
         tabWidth = node.offsetWidth / this.tabKeys.length,
-        distance = e.pageX - node.offsetLeft,
+        distance = e.pageX - node.getBoundingClientRect().left,
         index = parseInt(distance / tabWidth),
         targetKey = this.tabKeys[index] || false;
 
@@ -2049,7 +2049,7 @@ var TabGroup = React.createClass({
         this._index = false;
         this.handler.setParentOfToken(this.memberId);
       } else {
-        var distance = e.pageX - this.getDOMNode().offsetLeft;
+        var distance = e.pageX - this.getDOMNode().getBoundingClientRect().left;
         nextIndex = parseInt(distance / this.tabWidth);
       }
 
@@ -2085,7 +2085,7 @@ var TabGroup = React.createClass({
     var node = this.getDOMNode(),
       numTabsMod = this.ctx.ownerId == this.memberId ? 0 : 1,
       tabWidth = node.offsetWidth / (this.tabKeys.length + numTabsMod),
-      distance = e.pageX - node.offsetLeft,
+      distance = e.pageX - node.getBoundingClientRect().left,
       index = parseInt(distance / tabWidth);
 
     this.tabWidth = tabWidth;

diff --git a/dist/react-panels.min.js b/dist/react-panels.min.js
diff --git a/dist/react-panels.min.js.map b/dist/react-panels.min.js.map
diff --git a/index.js b/index.js
@@ -2017,7 +2017,7 @@ var TabGroup = React.createClass({
 
       var node = this.getDOMNode(),
         tabWidth = node.offsetWidth / this.tabKeys.length,
-        distance = e.pageX - node.offsetLeft,
+        distance = e.pageX - node.getBoundingClientRect().left,
         index = parseInt(distance / tabWidth),
         targetKey = this.tabKeys[index] || false;
 
@@ -2049,7 +2049,7 @@ var TabGroup = React.createClass({
         this._index = false;
         this.handler.setParentOfToken(this.memberId);
       } else {
-        var distance = e.pageX - this.getDOMNode().offsetLeft;
+        var distance = e.pageX - this.getDOMNode().getBoundingClientRect().left;
         nextIndex = parseInt(distance / this.tabWidth);
       }
 
@@ -2085,7 +2085,7 @@ var TabGroup = React.createClass({
     var node = this.getDOMNode(),
       numTabsMod = this.ctx.ownerId == this.memberId ? 0 : 1,
       tabWidth = node.offsetWidth / (this.tabKeys.length + numTabsMod),
-      distance = e.pageX - node.offsetLeft,
+      distance = e.pageX - node.getBoundingClientRect().left,
       index = parseInt(distance / tabWidth);
 
     this.tabWidth = tabWidth;

diff --git a/src/jsx/tab.js b/src/jsx/tab.js
@@ -73,7 +73,7 @@ var TabGroup = React.createClass({
 
       var node = this.getDOMNode(),
         tabWidth = node.offsetWidth / this.tabKeys.length,
-        distance = e.pageX - node.offsetLeft,
+        distance = e.pageX - node.getBoundingClientRect().left,
         index = parseInt(distance / tabWidth),
         targetKey = this.tabKeys[index] || false;
 
@@ -105,7 +105,7 @@ var TabGroup = React.createClass({
         this._index = false;
         this.handler.setParentOfToken(this.memberId);
       } else {
-        var distance = e.pageX - this.getDOMNode().offsetLeft;
+        var distance = e.pageX - this.getDOMNode().getBoundingClientRect().left;
         nextIndex = parseInt(distance / this.tabWidth);
       }
 
@@ -141,7 +141,7 @@ var TabGroup = React.createClass({
     var node = this.getDOMNode(),
       numTabsMod = this.ctx.ownerId == this.memberId ? 0 : 1,
       tabWidth = node.offsetWidth / (this.tabKeys.length + numTabsMod),
-      distance = e.pageX - node.offsetLeft,
+      distance = e.pageX - node.getBoundingClientRect().left,
       index = parseInt(distance / tabWidth);
 
     this.tabWidth = tabWidth;