Target netstandard2.1 and netcoreapp3.0 (#99)

.NET Core 2.1 introduced some runtime changes to support Span<T> and ByReference. Along with this comes the ability to do things like reinterpret memory as a different type. In .NET Framework the garbage collector couldn't track these references. These features proved useful enough that support for .NET Framework was dropped.

* Target netstandard2.1 and netcoreapp3.0
* Build: Zip native builds. Put version in zip filename
* Always build native exe on AppVeyor

GitVersion.yml

@@ -1,6 +1,6 @@
 mode: ContinuousDeployment
 increment: Patch
-next-version: 0.7.0
+next-version: 0.8.0
 branches:
   master:
     tag: alpha

appveyor.yml

@@ -4,5 +4,5 @@ environment:
   myget_api_key:
     secure: 0xJoYAtR6psXCRvk1qm5czDObkeRjHKPjfe5gIExXVFPwA0VVODYv/hBZYUtz2F3
 build_script:
-  - ps: .\build.ps1
+  - ps: .\build.ps1 appveyorbuild
 test: off

build/_build.csproj

@@ -10,8 +10,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageDownload Include="GitVersion.Tool" Version="[5.1.2]" />
-    <PackageReference Include="ILRepack.Lib" Version="2.0.18" NoWarn="NU1701" />
+    <PackageDownload Include="GitVersion.Tool" Version="[5.0.1]" />
     <PackageReference Include="NuGet.CommandLine" Version="5.3.1" />
     <PackageReference Include="Nuke.Common" Version="0.23.4" />
     <PackageReference Include="SharpZipLib" Version="1.2.0" />

src/LibHac/Common/SpanHelpers.cs

@@ -1,26 +1,16 @@
 using System;
 using System.Runtime.CompilerServices;
-
-#if NETCOREAPP
 using System.Runtime.InteropServices;
-#endif
 
 namespace LibHac.Common
 {
     public static class SpanHelpers
     {
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
-#if NETCOREAPP
         public static Span<T> CreateSpan<T>(ref T reference, int length)
         {
             return MemoryMarshal.CreateSpan(ref reference, length);
         }
-#else
-        public static unsafe Span<T> CreateSpan<T>(ref T reference, int length)
-        {
-            return new Span<T>(Unsafe.AsPointer(ref reference), length);
-        }
-#endif
 
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static Span<T> AsSpan<T>(ref T reference) where T : unmanaged
@@ -43,17 +33,10 @@ public static unsafe Span<T> CreateSpan<T>(ref T reference, int length)
         }
 
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
-#if NETCOREAPP
         public static ReadOnlySpan<T> CreateReadOnlySpan<T>(ref T reference, int length)
         {
             return MemoryMarshal.CreateReadOnlySpan(ref reference, length);
         }
-#else
-        public static unsafe ReadOnlySpan<T> CreateReadOnlySpan<T>(ref T reference, int length)
-        {
-            return new ReadOnlySpan<T>(Unsafe.AsPointer(ref reference), length);
-        }
-#endif
 
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static ReadOnlySpan<T> AsReadOnlySpan<T>(ref T reference) where T : unmanaged

src/LibHac/Common/StringUtils.cs

@@ -80,11 +80,7 @@ public static int Concat(Span<byte> dest, int destLength, ReadOnlySpan<byte> sou
 
         public static string Utf8ToString(ReadOnlySpan<byte> value)
         {
-#if STRING_SPAN
             return Encoding.UTF8.GetString(value);
-#else
-            return Encoding.UTF8.GetString(value.ToArray());
-#endif
         }
 
         public static string Utf8ZToString(ReadOnlySpan<byte> value)