Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new feature from numpy 1.13 #6064

Open
1 task
nouiz opened this issue Jun 21, 2017 · 2 comments
Open
1 task

Add new feature from numpy 1.13 #6064

nouiz opened this issue Jun 21, 2017 · 2 comments
Labels
Milestone

Comments

@nouiz
Copy link
Member

nouiz commented Jun 21, 2017

  • Run Theano tests with numpy 1.13

Should we create an equivalent of:

  • np.block
  • np.positive
  • np.isnat
  • np.heaviside
  • np.isin

old, but I think we didn't wrap them up to now:

  • np.fix
  • np.isposinf
  • np.isneginf
  • np.packbits
  • np.unpackbits

The error:

  • New AxisError: "Functions taking an axis argument, when that argument is out of range, now throw np.AxisError instead of a mixture of IndexError and ValueError. For backwards compatibility, AxisError subclasses both of these."

Behavior change:

  • "array == None and array != None do element-wise comparison."

https://github.com/numpy/numpy/blob/master/doc/release/1.13.0-notes.rst

@nouiz nouiz added this to the 0.10 milestone Jun 21, 2017
@lamblin
Copy link
Member

lamblin commented Jun 21, 2017

The last one (array == None) is important to change.
Things like packbits and unpackbits, I'm not convinced there is any value in adding that to Theano.
The rest could be nice to have if gradients make sense, or if a GPU implementation is done.

@nouiz
Copy link
Member Author

nouiz commented Jun 22, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants