Assertion failure when there are multiple versions of Enthought Canopy #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Canopy installed. For example, on my system, I get p2 like this: ['canopy-1.3.0.1715.rh5-x86_64', 'canopy-1.2.0.1610.rh5-x86_64', 'updates'] The for loop on Ln 239 will only remove the 'updates' in p2, which leads to the failure in the assert statement on Ln 242.
… list. So here's the modified assert statement to ensure that there's at least 1 element left in p2.
|
Thanks for the patch. The assert was there because if their is more then one, we always take the first in the list. I think we need to find which one we need to use and select this one. Do you know how we can get the canopy version to select the right one? |
Merged
|
PR gh-1746 fixed that in a way that make sure we use the good version, not just the first in the list. Thanks for the report and pointer to the fix/problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...nopy installed. For example, on my system, I get p2 like this:
['canopy-1.3.0.1715.rh5-x86_64', 'canopy-1.2.0.1610.rh5-x86_64', 'updates']
The for loop on Ln 239 will only remove the 'updates' in p2, which leads to the failure in the assert statement on Ln 242.