Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion failure when there are multiple versions of Enthought Canopy #1720

Closed
wants to merge 2 commits into from

Conversation

@hencrice
Copy link

hencrice commented Feb 1, 2014

...nopy installed. For example, on my system, I get p2 like this:

['canopy-1.3.0.1715.rh5-x86_64', 'canopy-1.2.0.1610.rh5-x86_64', 'updates']

The for loop on Ln 239 will only remove the 'updates' in p2, which leads to the failure in the assert statement on Ln 242.

hencrice added 2 commits Feb 1, 2014
… Canopy installed. For example, on my system, I get p2 like this:

['canopy-1.3.0.1715.rh5-x86_64', 'canopy-1.2.0.1610.rh5-x86_64', 'updates']

The for loop on Ln 239 will only remove the 'updates' in p2, which leads to the failure in the assert statement on Ln 242.
… list. So here's the modified assert statement to ensure that there's at least 1 element left in p2.
@nouiz

This comment has been minimized.

Copy link
Member

nouiz commented Feb 2, 2014

Thanks for the patch. The assert was there because if their is more then one, we always take the first in the list. I think we need to find which one we need to use and select this one. Do you know how we can get the canopy version to select the right one?

@nouiz nouiz mentioned this pull request Feb 21, 2014
@nouiz

This comment has been minimized.

Copy link
Member

nouiz commented Feb 21, 2014

PR gh-1746 fixed that in a way that make sure we use the good version, not just the first in the list. Thanks for the report and pointer to the fix/problem.

@nouiz nouiz closed this Feb 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.