max_pool_2d stride support #2424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase on the latest central/master? I think only one commit should be in that PR. |
| return [DownsampleFactorMaxGrad(self.ds, | ||
| ignore_border=self.ignore_border, | ||
| st=self.st)( | ||
| x, maxout, gz)] | ||
|
|
||
| def c_code(self, node, name, inp, out, sub): | ||
| "No implementation is currently for the case where |
There was a problem hiding this comment.
This should be a comment (starting with #), not a docstring.
Also, currently it is a parse error, as multi-line strings should be enclosed in triple marks (''' or """).
|
It looks like the tests you added can be quite long, and make travis time out. |
|
thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2196