numpy 1.12.0rc2 compatibility fix related to variable typecasting #5406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slefrancois
reviewed
Jan 13, 2017
| @@ -116,6 +117,11 @@ def make_node(self, n, p, shape): | |||
| n = tensor.as_tensor_variable(n) | |||
| p = tensor.as_tensor_variable(p) | |||
| shape = tensor.as_tensor_variable(shape) | |||
|
|
|||
| assert n.dtype in discrete_dtypes | |||
| assert p.dtype not in discrete_dtypes | |||
There was a problem hiding this comment.
p is a probability, shouldn't it be a float?
There was a problem hiding this comment.
yeah..so, change "assert p.dtype not in discrete_dtypes" to "assert p.dtype in float_dtypes" ?
There was a problem hiding this comment.
Let's try that, it will avoid user errors.
There was a problem hiding this comment.
sure, committed the changes.. also confirmed that the nosetests still pass
|
jenkins test this |
|
jenkins test this |
|
@nouiz , looks good to me once jenkins passes, can you double-check? |
|
ok for me too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for TypeError: Cannot cast array data from dtype('float32') to dtype('int64') according to the rule 'safe' can be fixed by making the cast explicit, casting="unsafe".
related to 5396