MAINT: collections import is deprecated #6664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twiecki
approved these changes
Nov 29, 2018
|
Thanks @andyfaff, LGTM! |
|
There is a slight problem in this PR that makes the code broken with Python 3.9.
|
|
A new PR is welcome. |
hroncok
added a commit
to hroncok/Theano
that referenced
this pull request
Feb 4, 2020
brandonwillard
pushed a commit
to brandonwillard/Theano
that referenced
this pull request
Mar 18, 2020
twiecki
pushed a commit
to aesara-devs/aesara
that referenced
this pull request
Apr 10, 2020
* Fix subtensor numpy warning * Fix simple typo: varible->size -> variable->size Closes #6734 * Counteract hypot redefinition for old Python versions * fix doc warning * Update extending_theano.txt * OrderedDict cannot be imported from collections.abc, it is not abstract See Theano/Theano#6664 (comment) * Move more collections.abc imports to theano.compat * Use math.gcd instead of fractions.gcd when possible fractions.gcd() function has been removed from Python 3.9, it was deprecated since Python 3.5. https://docs.python.org/3.9/whatsnew/3.9.html#removed * DOC: Allow building with Sphinx >= 2.0 * MAINT: Avoid SyntaxWarnings on import in Python 3.8 * flake8 code style fixes * DOC: Retain compatibility with older Sphinx * MAINT: Be compatible with numpy 1.17 and scipy 1.3 Fixes #6715. Includes and supersedes #6721. * flake8 code style fixes * Remove doctest in python 3.4 * Do not install sphinx_rtd_theme for python 3.4 as the installation doesn't work anymore. * fixing typo in GammaIncC Op * re-add min > max clip test with fixed reference * DOC: min > max clip may not match numpy * updating travis build for Python 3 * order of stages * conda activate * installing conda properly * conda install on travis * conda activate issues on travis * conda activate issues on travis * doctest needs older version of numpy * doctest * reverting setup.cfg * conda version conflicts * need old sphinx version * sphinx version * don't bother building docs * moved nosetester import * also moving known failures plugin Co-authored-by: Adrian Seyboldt <adrian.seyboldt@gmail.com> Co-authored-by: Frédéric Bastien <frederic.bastien@gmail.com> Co-authored-by: Tim Gates <tim.gates@iress.com> Co-authored-by: Marcel Bargull <marcel.bargull@udo.edu> Co-authored-by: Arnaud Bergeron <abergeron@gmail.com> Co-authored-by: Miro Hrončok <miro@hroncok.cz> Co-authored-by: Rebecca N. Palmer <rebecca_palmer@zoho.com> Co-authored-by: Frederic Bastien <fbastien@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Py37 importing from
collectionsis a DeprecationWarning and will become an Exception in Py38.