nvmath: Fix SSE detection logic #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some code assumed that `NV_CPU_X86 || NV_CPU_X86_64` is enough to check for SSE support, but that's wrong. There are plenty of older x86 CPUs which don't support SSE. Also fixed the SSE2 detection logic, previously it could not reach the `#elif __SSE2__` branch since __SSE__ is defined too when SSE2 is supported.
|
Thanks for the fix! |
akien-mga
added a commit
to godotengine/godot
that referenced
this pull request
Dec 15, 2017
Fixes #14709. Same as Thekla/thekla_atlas#11, but adding comments until it's merged upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some code assumed that
NV_CPU_X86 || NV_CPU_X86_64is enough to checkfor SSE support, but that's incorrect. There are plenty of older x86 CPUs
which don't support SSE (see this Godot Engine issue).
Also fixed the SSE2 detection logic, previously it could not reach the
#elif __SSE2__branch since__SSE__is defined too when SSE2 is supported.