Summary of some minor bugs

[UnitedThemes]

Hi,

since we found a few bugs, we don't want to open a new issue for each. So we sum it up here:

1.) Mega Menu Icons are broken, seems to be related to the other broken icons we reported. So please have an additional look into this issue as well.

2.) Autocomplete for Appearance -> Widgets -> Sidebars -> For Specific Pages seems to be broken.

3.) Addable Options do not have a handle text. It's hard to identify.

And a last questions. Is it possible to overwrite or extended an extension? We like to make a slight modification to the megamenu adding a separate icon output instead of having the output directly on the menu a tag. Again thanks for all your help and efforts. We really enjoy the framework.

Best Regards
UT

[ghost]

1.) Mega Menu Icons are broken, seems to be related to the other broken icons we reported. So please have an additional look into this issue as well.

You did not specify, but I think this happens in front-end because you created a theme from scratch and we had some css fixes in the default theme.

Please update to the latest version, edit and save again mega-menu icons and see if it works.

We changed the format of the option-type icon saved value.
Now the class is saved with the 'fa ' prefix.

In previous version it was saved fa-magic, in v1.1.3 it is saved fa fa-magic.

[ghost]

2.) Autocomplete for Appearance -> Widgets -> Sidebars -> For Specific Pages seems to be broken.

Will be fixed in the next version.

[UnitedThemes]

Hi,

yes it's a theme from scratch. I saw the data object change and after re-saving everything is fine :) Cheers

[ghost]

2.) Autocomplete for Appearance -> Widgets -> Sidebars -> For Specific Pages seems to be broken.

Fixed in v1.1.5. Please update

[UnitedThemes]

Works perfect! Thanks 👍

[ghost]

3.) Addable Options do not have a handle text. It's hard to identify.

Could you give us more details (maybe a screenshot) ?

[UnitedThemes]

of course, here you go.

[ghost]

We did not find a general solution to specify easy which option within the box to be used for the box title text. So you must do it manually by using addable box custom events. More details about option types custom events here.

To give you an idea, test this script by running it in the browser console:

(function($){
    var optionId = prompt('Enter addable-box option id (that one with "fw-option-type-addable-box" class)', 'fw-option-...');

    var $option = $('#'+ optionId);

    if (!$option.length) {
        console.log('No element found with id #'+ optionId);
        return;
    }

    $option.off('fw:option-type:addable-box:box:init.demo-example');

    $option.on('fw:option-type:addable-box:box:init.demo-example', function(e, data){
        console.log('[Debug event data]', $.extend(true, {}, data));

        /**
         * Select the option to get the text for the box title
         */
        var $titleOption = data.box.$options.find('input[type="text"]:first');

        /**
         * In this example we just get first text input.
         * You can add a special class or attribute to the option you want and select it like this:
         * $titleOption = data.box.$options.find('input[type="text"].my-special-class');
         */

         data.box.$titleText.text( $titleOption.val() );

         /**
          * Listen for option changes and update the box title
          */
         $titleOption.on('change', function(){
            data.box.$titleText.text( $titleOption.val() );
         });
    });
})(jQuery);

Then click on the "Add" button to add a new box.

[ghost]

As alternative, you can use the addable-popup option type

[ghost]

Is it possible to overwrite or extended an extension?

Overwrite - no. Extend - it depends on the extension and how it was made.

We like to make a slight modification to the megamenu adding a separate icon output instead of having the output directly on the menu a tag.

Currently there is no possibility to modify the generated megamenu html. It will be possible in a week or two. We will let you know.

If you urgently need that, you can:

1. Add the megamenu extension to the blacklist to disable it.
2. Copy the megamenu extension in child-theme/framework-customizations/extensions/united-megamenu and change it however you want.

[UnitedThemes]

Hi,

basically we like the idea of using the mentioned script to label the addable options. Going to use this for the moment.

And thanks for the feedback about the navigation. Looking forward for this update.

In meantime I found an issue with the multiselect inside the pagecreator media frame. It has a height of 28px. Here is a change to fix this issue.

option-types.css line 91-96 I added this right after

.fw-options-modal .media-frame select.fw-option-type-select-multiple {
height: auto;
}

I'm currently also unsure where to add new functions for the admin. For example I built a new option which works great but I needed a function which can be reused for other options as well. But haven't found a general place to insert it. For the moment it's located inside the options.php of the plugin.

Best Regards
UT

[ghost]

Thanks for the css fix.

I'm currently also unsure where to add new functions for the admin.

• If it's a helper function

  You can add helper functions in framework-customizations/theme/helpers.php (see directory structure).

• If it's a private function

  You can add private functions in a file located in includes/ directory, for example framework-customizations/theme/includes/private-functions.php.

For the moment it's located inside the options.php of the plugin.

What do you mean by Plugin?

[UnitedThemes]

Hi,

sorry used the word plugin but meant options type. Sorry about the confusion. Just to make sure, the helpers.php gets called earlier than the options inside the options folder?

[ghost]

Just to make sure, the helpers.php gets called earlier than the options inside the options folder?

Yes

[ghost]

In meantime I found an issue with the multiselect inside the pagecreator media frame. It has a height of 28px.

Fixed in v1.2.2

[UnitedThemes]

Thanks for the update. In meantime we recognized, that the appearance -> widgets -> sidebars -> For Specific Pages -> Blog Category only allows to query the first 10 sections inside the search field - section 11 ++ are not type able /searchable.

[ghost]

appearance -> widgets -> sidebars -> For Specific Pages -> Blog Category only allows to query the first 10 sections

Increased search results limit to 50 in v1.2.4

[UnitedThemes]

Hi,

perfect 👍

[UnitedThemes]

Hi,

currently not sure if it's an issue or if we miss something. But how to remove the SEO options from "Posts" > "Categories" ? We already found "excluded_taxonomies" inside the config.php under seo/seo-titles-metas/config.php - but post_tag is already included.

[GheorgheP]

There was a little mistake made on extension developing, it will be reflected on scratch-theme updates.
Here are the changes:
Find this code in scratch-parent/framework-customizations/extensions/seo/extensions/seo-titles-metas/class-fw-extension-seo-titles-metas.php:

foreach ( $excluded_taxonomies as $type ) {
    if ( isset( $post_types[ $type ] ) ) {
        unset( $post_types[ $type ] );
    }
}

And replace with:

foreach ( $excluded_taxonomies as $type ) {
    if ( isset( $taxonomies[ $type ] ) ) {
        unset( $taxonomies[ $type ] );
    }
}

Thanks for reporting this.

[ghost]

Fixed in v1.2.5

Note that the fix is not in the framework/, but in the theme framework-customizations/extensions/seo/extensions/seo-titles-metas/class-fw-extension-seo-titles-metas.php. The theme does not have automatic updates (like the framework), so you must update the framework-customizations/extensions/seo/extensions/seo-titles-metas/ extension manually. Sorry for that inconvenience.

[UnitedThemes]

Hi,

thanks for the mentioned fix. However we are having a questions about the theme options handling. When adding a new option , this option is not available until the theme settings have been saved. So the default value does also not take effect until saving, which leads me to the question ( it's untested yet ). If the theme gets activated, which theme options variables are available? Is there a way to declare a fallback value? like fw_get_db_settings_option('id' , $original_value, $fallback_value )

[ghost]

We knew about this problem but didn't fix it (added it in TODO as minor) because we were not sure what solution to use to be efficient.

But it seems to be a big inconvenience for the developers and now we fixed it in the v1.2.8 release.
We improved the fw_get_db_settings_option(), now it returns default option value from the settings options array if no value was found in the database.

[UnitedThemes]

Hi,

great news ! We found another small issue. While all metaboxes are currently deactivated by the extensions blacklist. The metabox called fw-options-box-main is still visible without any content.

[ghost]

all metaboxes are currently deactivated by the extensions blacklist

With extensions blacklist you deactivate extensions, not metaboxes. Meta box is an option.

Some extensions, using filters, inject their options in settings, post, or taxonomy terms options.

You can find the "main" metabox here and remove it manually.

[vbarbarosh]

We like to make a slight modification to the megamenu adding a separate icon output instead of having the output directly on the menu a tag.

Can you be more concrete?

[ghost]

Closing this due to inactivity.

@UnitedThemes , please reopen this issue when you will come back.