Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion] Typography option improvemants #195

Closed
danyj opened this issue Jan 28, 2015 · 4 comments
Closed

[suggestion] Typography option improvemants #195

danyj opened this issue Jan 28, 2015 · 4 comments
Assignees
Labels

Comments

@danyj
Copy link
Contributor

danyj commented Jan 28, 2015

I am not sure if this is already in but if not
can we have the typography option displayed without the font size and or font color.
Not sure if there is only font option.
Also finding a google font by name is tedious, can we have search input in dropdown please.

@ghost ghost assigned sergiubagrin Jan 28, 2015
@sergiubagrin
Copy link
Contributor

Not sure if there is only font option.

'copyright' => array(
    'label' => __( 'Copyright', 'fw' ),
    'desc'  => __( 'Please enter the copyright text', 'fw' ),
    'type'  => 'typography',
    'value' => array(
        'family' => 'Arial',
        'style'  => '400',
        'color'  => '#000000'
    ),
    'components'    =>array(
        'size'  => false,
        'color' => false
    )
)

Also finding a google font by name is tedious, can we have search input in dropdown please.

We thought to add a search in typography dropdown. We decided that this is not a good solution. For an End User Font Name is equal with 0 it is more relevant to add Font Type in Typography dropdown: http://screencast.com/t/5JoG7MuROGK

@danyj
Copy link
Contributor Author

danyj commented Jan 29, 2015

OK thnx for the info
You might want to add the info about components array here .
http://manual.unyson.io/en/latest/options/built-in-option-types.html#typography

@ghost ghost assigned valeriuzdrobau and unassigned sergiubagrin Jan 29, 2015
@danyj
Copy link
Contributor Author

danyj commented Jan 29, 2015

Can we please have the option line up correctly if one of the components has been disabled.
Currently with disabled size and color it looks like this
http://screencast.com/t/ZneKt2xhoZb
so the tooltip and the description are both off.
otherwise it looks ok if no component has been disabled.
http://screencast.com/t/gOjGJZzP

@danyj
Copy link
Contributor Author

danyj commented Jan 29, 2015

also on that second image the letter X in font size is not visible so all you see is
12p. Some side padding might be useful there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants