[Patch 1] Added New Componen DateRangeSelector.tsx #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DevFreAkeD is attempting to deploy a commit to the Streamability Team on Vercel. A member of the Team first needs to authorize it. |
Thenlie
requested changes
May 23, 2024
Comment on lines
+3
to
+5
| // Before Using Install the required dependencies | ||
| /*npm install react-datepicker | ||
| npm install date-fns*/ |
There was a problem hiding this comment.
These changes can be added to the package.json. Rather than manually installing these dependencies each time, a new dev should only need to run npm install to get everything they need.
|
We should also make a storybook story for this component. You can get more information on that here https://github.com/Thenlie/Streamability/blob/main/docs/storybook.md. Let me know if you have any questions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added New Componen DateRangeSelector.tsx
Checklist
developnotmain)feature,documentation, etc.)git rebase developif necessarynpm run todo-ciran if any todo comments were created