Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScriptProcessorNode deprecation warnings #88

Open
gherkins opened this issue Jun 6, 2022 · 1 comment
Open

ScriptProcessorNode deprecation warnings #88

gherkins opened this issue Jun 6, 2022 · 1 comment

Comments

@gherkins
Copy link

gherkins commented Jun 6, 2022

Some FX-Types rely on the deprecated ScriptProcessorNode and will produce the following console warning

The ScriptProcessorNode is deprecated. Use AudioWorkletNode instead.

Happens for example with FX-Types Chorus, Phaser, Tremolo & WahWah
because of: https://github.com/Theodeus/tuna/search?q=createScriptProcessor

see
https://developer.mozilla.org/en-US/docs/Web/API/ScriptProcessorNode
https://developer.mozilla.org/en-US/docs/Web/API/BaseAudioContext/createScriptProcessor
https://stackoverflow.com/questions/48874118/porting-scriptprocessor-based-application-to-audioworklet

@gherkins gherkins changed the title The ScriptProcessorNode is deprecated. Use AudioWorkletNode instead. ScriptProcessorNode deprecation warnings Jun 6, 2022
1j01 added a commit to 1j01/guitar that referenced this issue Apr 9, 2023
1. createScriptProcessor is used in tuna.js anyways, so it will need
   updating in order to actually do away with the warnings,
   and avoid future bit rot.
   Theodeus/tuna#88
   https://stackoverflow.com/questions/68007500/how-to-migrate-to-audioworkletnode-from-scriptprocessornode
   I could send a PR, or perhaps switch to a different effects chain.
2. String bending doesn't work
3. Maybe there's an error that can occur where fret is undefined?
   Note implicit assignment at play: (@fret)->
   Note there's GuitarStringProcessor::play and GuitarString::play
@felixniemeyer
Copy link

I'd like to see node implementations moved to audio worklets (the modern way of implementing custom audio nodes as I understand).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants