rules: check-custom-hook-dependencies has better regex to match less

The original one was inspired by the documentation and makes little sense.
denis-sokolov · Jul 8, 2021 · 014ba7b · 014ba7b
1 parent fea1bfb
commit 014ba7b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/configs/index.ts b/src/configs/index.ts
@@ -147,7 +147,7 @@ const recommended = {
     "react-hooks/exhaustive-deps": "error",
     "@theorem/check-custom-hook-dependencies": [
       "error",
-      { additionalHooks: "(use.+(Callback|Effect|Memo))" },
+      { additionalHooks: "^use.+(Callback|Effect|Memo)$" },
     ],
   },
   settings: { react: { version: "detect" } },

diff --git a/src/rules/check-custom-hook-dependencies.test.ts b/src/rules/check-custom-hook-dependencies.test.ts
@@ -24,6 +24,6 @@ import rule from "./check-custom-hook-dependencies";
   "function F(){ const a = useState(); useMyEffect(() => { console.log(a); }, []); }",
 ].forEach((code, i) =>
   invalid(`check-custom-hook-dependencies invalid ${i}`, rule, code, {
-    ruleOptions: [{ additionalHooks: "(useMyEffect)" }],
+    ruleOptions: [{ additionalHooks: "^useMyEffect$" }],
   })
 );