[IMP] override_mail_recipients. Allow whitelisted domain.

[NL66278]

This was done for a customer that still wanted to test emails send to their own addresses, but still making certain no other of their partners receive emails.

Apart from the new domain whitelist functionality, I moved the send_email to the top of the code, according to the principle that main functions should be above helper functions.

(Editted after following up on the suggestions of @hbrunn ).

[hbrunn]

if I understand correctly, filling in @therp.nl will fail all mails going to non-therp.nl addresses, but will allow a mail to someone@therp.nl unchanged? So it's basically a filter for outgoing mails? That would overstretch the purpose of this module in my opinion and merit its own module.

But with a slight change I think this will be a great addition here: Can't we introduce another config parameter for the whitelisting which is a comma separated list of domains, and those won't be touched by the override? This way, they can test internal mails just fine, and external mails go to odoomailtest@customer or whatever is filled into the override parameter? Seems even like added value to me.

[hbrunn]

PS: No idea what's going on with travis

[NL66278]

You understood correctly. I will go the extra mile and do it this way.

[hbrunn]

for what it's worth, I updated our fork of MTQ and now we're happily green

[codecov-io]

Codecov Report

Merging #104 into 11.0 will increase coverage by 10.87%.
The diff coverage is 95.65%.

@@             Coverage Diff             @@
##             11.0     #104       +/-   ##
===========================================
+ Coverage   80.55%   91.42%   +10.87%     
===========================================
  Files           2        2               
  Lines          36       70       +34     
===========================================
+ Hits           29       64       +35     
+ Misses          7        6        -1

Impacted Files	Coverage Δ
override_mail_recipients/models/ir_mail_server.py	96.42% <95.65%> (+10.06%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a662450...8b20aad. Read the comment docs.

[hbrunn]

please add bf6b463 or something similar to make this not fail on new installations