Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Laubwerk Plants and Python folders #20

Closed
dvhart opened this issue Jun 14, 2020 · 7 comments
Closed

Separate Laubwerk Plants and Python folders #20

dvhart opened this issue Jun 14, 2020 · 7 comments
Labels
enhancement New feature or request

Comments

@dvhart
Copy link
Collaborator

dvhart commented Jun 14, 2020

John Payne reports that attempting to change the installation path of a Laubwerk Plant Kit on Windows will install the Plants at the specified destination, but the Python SDK is still installed in "C:\Program Files".

If this is by design, the Thicket Add-on preferences may need to allow specifying the Plants and Python folders individually, rather than assume they both exist under a common Laubwerk installation path.

Need to confirm intent with Laubwerk.

@dvhart dvhart added the enhancement New feature or request label Jun 14, 2020
@dvhart
Copy link
Collaborator Author

dvhart commented Jun 14, 2020

The current Add-on preferences panel provides a single Laubwerk Install Path to configure. To address this issue, the proposed fix would be to include two paths to configure, one for Plants and one for Python.
thicket-prefs

dvhart added a commit that referenced this issue Jun 15, 2020
The Laubwerk Plant Kits allow the user to specify different locations
for the Plants and the Python Extension. Allow for this by specifying
the two paths individually in the Addon Preferences, rather than
assuming a single top level Laubwerk install path.

To be able to check the two paths and provide meaningful error messages
in the preferences panel, convert the ThicketStatus object from an enum
to a simple object with several bool members. Change the lbw_sdk_valid
semantics to mean the laubwerk module was successfully loaded. Drop the
rebuild_db state as this is equivalent to the ready state.

Simplify installation for the common case by providing default paths for
both Windows and Mac (Darwin) users via the platform.system() call.

Fixes: Issue #20: Separate Laubwerk Plants and Python folders

Signed-off-by: Darren Hart <dvhart@infradead.org>
dvhart added a commit that referenced this issue Jun 15, 2020
The Laubwerk Plant Kits allow the user to specify different locations
for the Plants and the Python Extension. Allow for this by specifying
the two paths individually in the Addon Preferences, rather than
assuming a single top level Laubwerk install path.

To be able to check the two paths and provide meaningful error messages
in the preferences panel, convert the ThicketStatus object from an enum
to a simple object with several bool members. Change the lbw_sdk_valid
semantics to mean the laubwerk module was successfully loaded. Drop the
rebuild_db state as this is equivalent to the ready state.

Simplify installation for the common case by providing default paths for
both Windows and Mac (Darwin) users via the platform.system() call.

Fixes: Issue #20: Separate Laubwerk Plants and Python folders

Signed-off-by: Darren Hart <dvhart@infradead.org>
@dvhart
Copy link
Collaborator Author

dvhart commented Jun 15, 2020

The experimental v0_3_1-alpha2 release contains the lbw-paths branch including the updated preferences panel show below:

Screen Shot 2020-06-14 at 6 59 12 PM

dvhart added a commit that referenced this issue Jun 21, 2020
The Laubwerk Plant Kits allow the user to specify different locations
for the Plants and the Python Extension. Allow for this by specifying
the two paths individually in the Addon Preferences, rather than
assuming a single top level Laubwerk install path.

To be able to check the two paths and provide meaningful error messages
in the preferences panel, convert the ThicketStatus object from an enum
to a simple object with several bool members. Change the lbw_sdk_valid
semantics to mean the laubwerk module was successfully loaded. Drop the
rebuild_db state as this is equivalent to the ready state.

Simplify installation for the common case by providing default paths for
both Windows and Mac (Darwin) users via the platform.system() call.

Fixes: Issue #20: Separate Laubwerk Plants and Python folders

Signed-off-by: Darren Hart <dvhart@infradead.org>
dvhart added a commit that referenced this issue Jun 21, 2020
The Laubwerk Plant Kits allow the user to specify different locations
for the Plants and the Python Extension. Allow for this by specifying
the two paths individually in the Addon Preferences, rather than
assuming a single top level Laubwerk install path.

To be able to check the two paths and provide meaningful error messages
in the preferences panel, convert the ThicketStatus object from an enum
to a simple object with several bool members. Change the lbw_sdk_valid
semantics to mean the laubwerk module was successfully loaded. Drop the
rebuild_db state as this is equivalent to the ready state.

Simplify installation for the common case by providing default paths for
both Windows and Mac (Darwin) users via the platform.system() call.

Fixes: Issue #20: Separate Laubwerk Plants and Python folders

Signed-off-by: Darren Hart <dvhart@infradead.org>
@dvhart
Copy link
Collaborator Author

dvhart commented Jun 21, 2020

Resolved in release v0_3_1.

@dvhart dvhart closed this as completed Jun 21, 2020
@mheljune
Copy link

hi, how do i fix this, theres an error turning on the add on
error

Latest from GitHub (for testers and developers)
Exit Blender
Clone the thicket git repository into the Blender addons folder:
Mac: ~/Library/Blender/2.80/scripts/addons/thicket
Windows: %AppData%\Blender Foundation\Blender\2.80\scripts\addons\thicket
Start Blender

@dvhart
Copy link
Collaborator Author

dvhart commented Oct 19, 2020

@mheljune moved this to a new issue #28

@mheljune
Copy link

error

i've downloaded the latest laubwerk 1.0.34 and i install it with custom, it seems it doesn't compatible in my pc?

@dvhart
Copy link
Collaborator Author

dvhart commented Oct 20, 2020

Hi @mheljune , let's please address this in Issue #28 , I'll follow up there. This issue, #20, is unrelated to the problem you are running to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants