Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OWM One Call API #183

Merged
merged 3 commits into from
Aug 20, 2020
Merged

Conversation

c-klinger
Copy link
Contributor

@c-klinger c-klinger commented Apr 19, 2020

https://openweather.co.uk/blog/post/new-one-call-api-essential-weather-data

Fixes #182

@marcelstoer marcelstoer changed the title #182 Added implementation of JsonListener for parsing One Call Endpoi… #182 Add support for OWM One Call API Apr 20, 2020
@marcelstoer
Copy link
Member

Looks fine, thanks for your contribution:

  • Can you please add an example along the lines of the existing OpenWeatherMapForecastDemo or OpenWeatherMapCurrentDemo
  • There is undoubtedly value in self-contained OpenWeatherMapXYZ .h and .cpp files. However, it also adds maintenance overhead as large chunks of code are inevitably identical. Reuse by copy-pasting code is never ideal. How do you feel about refactoring the (now three) integrated APIs under a common umbrella? Any thoughts on this?

@marcelstoer marcelstoer changed the title #182 Add support for OWM One Call API Add support for OWM One Call API May 3, 2020
@marcelstoer marcelstoer merged commit c5a9ad7 into ThingPulse:master Aug 20, 2020
zhzhzhy added a commit to zhzhzhy/esp8266-weather-station that referenced this pull request Jan 22, 2021
Add support for OWM One Call API (ThingPulse#183)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support OpenWeatherMap One Call API
2 participants