Script to add license header info #475
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can test this on Windows, if not this week then early next. Will report back as soon as I do. |
|
Just confirmed this works on Windows (using Cygwin w/ Python and git installed). Nice work, Amy. I'll add notes to README.md on usage and merge into master. |
|
Done: Two notes: I had to replace os.rename with shutil.move because it was throwing an error on Cygwin/Windows. shutil.move works everywhere, error free. Also, I added lic_header.py to .gitignore so no one checks in their modified script. The pre-commit hook file is the same on Windows, works the same way. Grateful to have this, thanks again. |
Great, thanks very much for figuring that one out. |
unruthless
pushed a commit
to unruthless/ThinkUp
that referenced
this pull request
Apr 27, 2011
…s, can be used as a git pre-commit hook * Replaced use of os.rename to shutil.move to avoid this error on Windows/Cygwin: http://bytes.com/topic/python/answers/41652-errno-18-invalid-cross-device-link-using-os-rename * Added lic_header.py to .gitignore * Added usage instructions to README.md
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the official pull req. for the precommit script which checks for and adds header information as necessary.
Here is the information about it:
http://groups.google.com/group/thinkupapp/msg/281302a1d585f1ae?hl=en
In brief, the idea is that if the script finds and modifies any files that are missing header info, the commit does not go through, and the user checks the new mods to make sure things are okay and 'adds' those files again. The second commit should then complete.
I have tested it on osx, and it should run the same on linux. It does require that python be installed, of course.
I have not tested it on Windows, as I am not set up to easily do that.
However, setup is probably a bit different on Windows, in particular the content of the .git/hooks/pre-commit file (see link above). It would also be good to double check that there are no script path name issues in windows. [However, there should not be].
Would one of you be set up to do a windows test?