Start support for workspace: protocol for internal packages
#186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d6ecc76 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
petervmeijgaard
added a commit
to vivid-web/pusher-react
that referenced
this pull request
Oct 19, 2023
Hopefully this MR gets merged soon: Thinkmill/manypkg#186
petervmeijgaard
added a commit
to vivid-web/pusher-react
that referenced
this pull request
Oct 19, 2023
Hopefully this MR gets merged soon: Thinkmill/manypkg#186
|
Does the maintainer hate pnpm? 😵💫 |
|
We would also love to have this supported out of the box in manypkg |
|
Thanks so much for this PR and sorry for taking so long on this, I wanted to take a slightly different approach to what's in this PR so I've added support for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts support for the
workspace:protocol and does many of the things as discussed in #72 to make this tool usable with pnpm.I think the code is pretty self-explanatory, also added a bunch of test for coverage.
Explicitly opts out of trying to fix errors, because I'm not sure whether that's 1) safe to do and/or 2) desired in all cases. I know in my own test workloads it's not what I want.
An option could be added to prefer the
workspace:protocol but that's also outside the scope of this PR.