Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix start directory for getPackages #201

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Fix start directory for getPackages #201

merged 3 commits into from
Mar 15, 2024

Conversation

manzoorwanijk
Copy link
Contributor

Fixes #200

This PR updates getPackages to start looking from the monorepo root, instead of the passed dir

Copy link

changeset-bot bot commented Jan 19, 2024

🦋 Changeset detected

Latest commit: 7c1acbe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@manypkg/get-packages Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@manzoorwanijk
Copy link
Contributor Author

@Andarist default branch is main but .changeset/config.json does not reflect that - "baseBranch": "main"

Copy link
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emmatown emmatown merged commit 3c9641c into Thinkmill:main Mar 15, 2024
@github-actions github-actions bot mentioned this pull request Mar 15, 2024
@manzoorwanijk manzoorwanijk deleted the fix/get-packages-root-dir branch March 15, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getPackages fails when given a monorepo subdirectory instead of root directory.
2 participants