Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: As a GolemDev, I would like 0-dev_history to not be added #187

Closed
2 tasks done
ColinFay opened this issue Feb 21, 2023 · 2 comments · Fixed by #216
Closed
2 tasks done

feat: As a GolemDev, I would like 0-dev_history to not be added #187

ColinFay opened this issue Feb 21, 2023 · 2 comments · Fixed by #216

Comments

@ColinFay
Copy link
Member

ColinFay commented Feb 21, 2023

Validation

  • Documentation explicitly state that using the "additional" template does not override or add a 0-dev_history.Rmd.
    image

  • There is a section on how to use {fusen} with {golem} in the Tips and tricks vignette.
    image

Context

i'm not sure the dev_history file should be enforced on project that weren't initialized with {fusen}, or at least there should be an option to ignore it.

When dev with {golem}, forcing this file is redundant with what you've got in other files.

Reprex :

colinfay@Colins-MBP ~ % cd /tmp 
colinfay@Colins-MBP /tmp % Rscript -e "golem::create_golem('pif')"
[REDACTED]
A new golem named pif was created at pif .
To continue working on your app, start editing the 01_start.R file.
colinfay@Colins-MBP /tmp % cd pif 
colinfay@Colins-MBP pif % Rscript -e "fusen::add_minimal(flat_name = 'graph')"
File .here already exists in /private/tmp/pif
[1] "/private/tmp/pif/dev/flat_graph.Rmd"   
[2] "/private/tmp/pif/dev/0-dev_history.Rmd"

Validation

  • If I run fusen::add_mininal() in a golem project, I don't have 0-dev_history
@ALanguillaume
Copy link
Member

@ColinFay you need to use fusen::add_additional() for that purpose. It will only add a new flat file and no 0-dev_history.Rmd

Re-reading the documentation, I realised that it is not explicitly mentionned anywere.

May be we can:

  • explicitly state that using the "additional" template does not override or add a 0-dev_history.Rmd.
  • Add a section on how to use {fusen} with {golem} in the Tips and tricks vignette.

@statnmap
Copy link
Member

statnmap commented Jun 2, 2023

This issue is listed in the future roadmap. It will be re-opened when necessary. See: https://github.com/ThinkR-open/fusen/wiki/Future-road-map

@statnmap statnmap closed this as not planned Won't fix, can't repro, duplicate, stale Jun 2, 2023
statnmap added a commit that referenced this issue Jun 13, 2023
tags: feat, doc, test

- "minimal" was ambiguous as to be minimal flat file or minimal package structure.
- "minimal" does not exist anymore, it is replaced with "minimal_package" or "minimal_flat"

issue #187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants