Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Linux install command #1129

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Stehlampe2020
Copy link

@Stehlampe2020 Stehlampe2020 commented Jun 23, 2024

Related Issue/Addition to code

  • Addition to code.

Type of change

  • Bug fix (non-breaking change)

Proposed Changes

  • update the Linux install command to remove the danger of executing a failed download

Why is this change needed?

It's needed because, as described below, executing a failed download can potentially be dangerous.

Additional Info

  • Piping straight from the internet into any shell can be dangerous, because if the download only partially succeeds there can be commands created that way from legit commands that instead cause harm. The new command first downloads the file fully and only if it downloads error-free tries to execute it through bash.

Checklist:

  • My code follows the style guidelines of this project and I have read CONTRIBUTING.md
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas (N/A)
  • I have made corresponding changes to the documentation (N/A)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules (N/A)
  • I have checked my code and corrected any misspellings

Screenshots

Original Updated
Screenshot_20240623_124411 Screenshot_20240623_124443

Piping straight from the internet into any shell can be dangerous, because if the download only partially succeeds there can be commands created that way from legit commands that instead cause harm. 
The new command first downloads the file fully and only if it downloads error-free tries to execute it through bash.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant