Properly configure docker environment. #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) from 48.2.3 to 48.2.4. - [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases) - [Changelog](https://github.com/gajus/eslint-plugin-jsdoc/blob/main/.releaserc) - [Commits](gajus/eslint-plugin-jsdoc@v48.2.3...v48.2.4) --- updated-dependencies: - dependency-name: eslint-plugin-jsdoc dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…ot/npm_and_yarn/eslint-plugin-jsdoc-48.2.4 chore(deps): bump eslint-plugin-jsdoc from 48.2.3 to 48.2.4
Bumps [chai-as-promised](https://github.com/domenic/chai-as-promised) from 7.1.1 to 7.1.2. - [Release notes](https://github.com/domenic/chai-as-promised/releases) - [Commits](chaijs/chai-as-promised@v7.1.1...v7.1.2) --- updated-dependencies: - dependency-name: chai-as-promised dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…ot/npm_and_yarn/chai-as-promised-7.1.2 chore(deps-dev): bump chai-as-promised from 7.1.1 to 7.1.2
Adds a workflow to build and publish to Github Container Registry.
The following docker fixes are in place: - transitions to using npm in docker. - removes extraneous comments and environmental variables in dockerfile. The following compose fixes are in place: - adds a networking layer - uses the correct mysql 8.4 auth plugin call - removes the extraneous UTF8 variables - removes the deprecated version tag
The mysql dockerfile has been pinned at 8.3 to avoid errors in the default authentication plugin. See mysqljs/mysql#2233 for more information. It might be prudent to switch to mysql2 instead of mysqljs for future release. I've renamed all the server model files to have a numeric prefix to allow execution in order. The 99-debug.sql file crashes, but it is not necessary for the functioning of the BHIMA server. You can now type `docker-compose up` and be taken to the BHIMA installation page on localhost. Environmental variables are set in the `.env` file as usual.
Renames the sql files everywhere they are referenced to their new alphanumeric names.
Fixes the typo sever to server.
Fixes an issue with the user/password not being synchronized between the bhima and mysql containers.
Adds the workflow_dispatch trigger to manually trigger docker builds from the actions menu.
Creates the .env specifically for docker that omits key variables needed to be defined at runtime by the user.
Adds the .env to the ignored files list.
Uses dockerhub to avoid the GCR's permissions issues. The docker-compose file should now be able to run BHIMA without any further configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly configures the .env files for docker by including a .env.docker file.
It also uses dockerhub for the distribution of the application.