Update prettier config, add eslint, remove package-lock.json #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwcsquared
reviewed
Feb 18, 2019
| } | ||
|
|
||
| export const aberrationRatio = (rect: Rect, height: number, amt: number) => | ||
| (height - rect.top - rect.bottom) / height * amt; | ||
| ((height - rect.top - rect.bottom) / height) * amt |
There was a problem hiding this comment.
lol, prettier did that!
pwcsquared
reviewed
Feb 18, 2019
| const { height } = useWindowSize(); | ||
| const [rect, setRect] = useState({top: 0, bottom: 0}); | ||
| const [ratio, setRatio] = useState(0); | ||
| const Aberration: FunctionComponent<{ text?: string }> = ({ text }) => { |
There was a problem hiding this comment.
Is importing FunctionComponent from react a special typescript thing?
There was a problem hiding this comment.
Yep, that's the type for a function component. It used to be SFC but that name was deprecated since "stateless functional component" was kind of a misnomer, given function components can now have state, with hooks!
|
Looks good! Let's revisit eslint later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
VS Code was yelling at me about ESLint not being found. I had installed the Prettier extension and noticed some of the code wasn't getting formatted correctly. Those issues seem to be resolved with these changes. I followed Prettier's recommendations for integrating with ESLint.
Also I wanted to try out the new eslint rule that will check react hooks.. haven't been able to get the warnings to display yet, so maybe we should wait to merge this until I can get it working.
Links
eslint-plugin-react-hooks
using Prettier alongside ESLint