Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker container #41

Open
AnderssonPeter opened this issue May 12, 2018 · 9 comments
Open

Docker container #41

AnderssonPeter opened this issue May 12, 2018 · 9 comments

Comments

@AnderssonPeter
Copy link

Any chance you could create a docker container for raspberry pi 3?

@ThomDietrich
Copy link
Owner

Hey, I am not using docker on the RPi but please provide a Dockerfile if you build one. Shouldn't be too hard. I imagine a base image plus a set of RUN instructions for what is already documented here: https://github.com/ThomDietrich/miflora-mqtt-daemon#installation

@LarsAC
Copy link
Contributor

LarsAC commented May 28, 2018

For Docker it is somehow disturbing that the app file (.py) and config.ini reside in the same directory. I made a change to allow for an additional config directory command line argument. Then, this could be stored in a permanent volume, whereas the code and its dependencies would be inside the container.

One I find out how to create a PR, I will do so.

Lars

@ThomDietrich
Copy link
Owner

Sounds reasonable. Let's make it a configurable config file argument though. Please send a PR our way ;)

@LarsAC
Copy link
Contributor

LarsAC commented May 30, 2018

Did so along with a fix for #39. This is my first PR ever and I am very excited ;-)

Please advice if this stuff works for you.

Lars

@iicky
Copy link

iicky commented Aug 31, 2018

The Dockerfile works great on a RPi 3 (ARMv8), but not for a RPi 0 (ARMv6). Here's the error

Step 3/10 : RUN mkdir -p /usr/src/app
 ---> Running in bc5f5ed8eedf
ERROR: Service 'miflora-mqtt-daemon' failed to build: The command '/bin/sh -c mkdir -p /usr/src/app' returned a non-zero code: 139

I switched the image to FROM resin/raspberry-pi-python:3.6.1 and the Python call to CMD [ "python", "./miflora-mqtt-daemon.py", "--config_dir", "/config" ] and it spins up.

@ThomDietrich
Copy link
Owner

@LarsAC would you like to create a tested PR for this change by @iicky

@iicky thanks!

@LarsAC
Copy link
Contributor

LarsAC commented Nov 8, 2018

Can do, will add a second Dockerfile for rpi.

Lars

@RaymondMouthaan
Copy link

RaymondMouthaan commented Nov 13, 2018

Please consider PR #59, for arm32v6 (RPI 1, 2, 3 and Zero), arm32v7 (RPI 1, 2, 3) and arm64v8 (pine64) support.

Ray

@bigkraig
Copy link

👍 can we also get this into the hassio addons repository? its possible to scrape miflora sensors from hass directly, but the units & names in the miflora component do not align with the units/names created with this daemon. I'd prefer to just use this tool everywhere and turn off the miflora component completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants