Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: clojurescript (plain) #59

Closed

Conversation

Thomas-Boi
Copy link
Owner

@Thomas-Boi Thomas-Boi commented Aug 10, 2021


name: Pull Request Template
about: Add a new icon or feature to the repo.
title: 'New Icon/Feature: [NAME]'
assignees: ''


New Icon Section

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

Link to prove your SVG is correct and up-to-date.

https://clojurescript.org/

@Thomas-Boi Thomas-Boi added the bot:peek Use this label so GitHub Actions bot can peek at the new icons that label Aug 10, 2021
@github-actions
Copy link

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs. This is how Icomoon intepret the uploaded SVGs:
Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons. This is what the font will look like:
Imgur Images

You can click on the pictures and zoom on them if needed.

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs.
Check this doc for more details and fix the issues as
instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repo.

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Thomas-Boi and others added 3 commits August 10, 2021 10:51
* Fix issues with npm security (#793)
* Updated gulp
* Update sass in gulpfile
* Add gulp-footer
* Change gulp-footer to devDepend
Co-authored-by: David Leal <halfpacho@gmail.com>
@Thomas-Boi Thomas-Boi closed this Aug 12, 2021
@Thomas-Boi Thomas-Boi deleted the thomas/icons/clojurescript branch August 12, 2021 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label so GitHub Actions bot can peek at the new icons that
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants