Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded Rustler dependencies to 0.30, to work with OTP 26 #6

Merged
merged 2 commits into from
Nov 12, 2023
Merged

Upgraded Rustler dependencies to 0.30, to work with OTP 26 #6

merged 2 commits into from
Nov 12, 2023

Conversation

madclaws
Copy link
Contributor

What?

Upgraded Rustler Elixir and Rust dependencies to 0.30

Why?

The current blake3 elixir library was not compiling with OTP 26 and was giving error.

Compiling crate blake3 in release mode (native/blake3)
   Compiling rustler v0.22.2
error: failed to run custom build command for `rustler v0.22.2`

Caused by:
  process didn't exit successfully: `/home/madclaws/labs/blake3/_build/dev/lib/blake3/native/blake3/release/build/rustler-aff052536a2e5df6/build-script-build` (exit status: 101)
  --- stderr
  thread 'main' panicked at /home/madclaws/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rustler-0.22.2/build.rs:37:13:
  Erlang version 2.17 not handled, please file a a bug report.
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

== Compilation error in file lib/blake3/native.ex ==
** (RuntimeError) Rust NIF compile error (rustc exit code 101)
    (rustler 0.30.0) lib/rustler/compiler.ex:36: Rustler.Compiler.compile_crate/3
    lib/blake3/native.ex:7: (module)

Testing

  • Unit tests are working fine.
  • Have added new Elixir and Erlang versions to the ci.yml

@Thomas-Jean Thomas-Jean merged commit 01bd03a into Thomas-Jean:master Nov 12, 2023
@Thomas-Jean
Copy link
Owner

@madclaws Thank you for the fix! I dropped 1.12 from the test matrix due to an issue with Application.compile_env/3 your changes should be available in 1.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants