Skip to content
This repository has been archived by the owner on Feb 29, 2024. It is now read-only.

remove depracated features #511

Merged
merged 9 commits into from
Jul 15, 2023
Merged

remove depracated features #511

merged 9 commits into from
Jul 15, 2023

Conversation

Thomas55555
Copy link
Owner

@Thomas55555 Thomas55555 commented Jul 10, 2023

@Thomas55555 Thomas55555 marked this pull request as ready for review July 10, 2023 21:46
@prairiesnpr
Copy link
Collaborator

prairiesnpr commented Jul 10, 2023

Everything looks good, just not certain I understand the reason for removing the battery and status from the vacuum entity. Is there an upcoming depreciation in HA that I missed?

Current State:
Screenshot 2023-07-10 at 19 44 12

After Removal:
Screenshot 2023-07-10 at 19 43 49

@Thomas55555
Copy link
Owner Author

There is a blog post...
I've added it to the description.
And the status attribute is not even documented anymore, although it works.

@prairiesnpr
Copy link
Collaborator

There is a blog post... I've added it to the description. And the status attribute is not even documented anymore, although it works.

Got it, not sure I understand the reasoning on HA removing them, but looks like that's where we are. I'm good, thanks.

@prairiesnpr
Copy link
Collaborator

We may want to consider retaining the status field as a separate sensor, if we find anyone used it.

@Thomas55555
Copy link
Owner Author

I think some people use it indeed.
But in the status is only information, which is already somewhere else. I don't think it's necessary to have redundant information.

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03 ⚠️

Comparison is base (cfe2bcd) 99.00% compared to head (a714973) 98.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #511      +/-   ##
==========================================
- Coverage   99.00%   98.97%   -0.03%     
==========================================
  Files          16       16              
  Lines        1302     1270      -32     
==========================================
- Hits         1289     1257      -32     
  Misses         13       13              
Impacted Files Coverage Δ
custom_components/husqvarna_automower/const.py 100.00% <ø> (ø)
custom_components/husqvarna_automower/sensor.py 100.00% <100.00%> (ø)
custom_components/husqvarna_automower/vacuum.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Thomas55555
Copy link
Owner Author

for error, see: home-assistant/developers.home-assistant#1836

@prairiesnpr
Copy link
Collaborator

Do you mind if we merge #512 then rebase this PR? Especially since we have now removed the HusqvarnaAutomowerStateMixin.

@Thomas55555
Copy link
Owner Author

Okay, I'm ready.

@Thomas55555 Thomas55555 merged commit 367e593 into main Jul 15, 2023
10 checks passed
@delete-merged-branch delete-merged-branch bot deleted the remove-depracated-features branch July 15, 2023 12:34
@HenrikBachGravesen
Copy link

A comment for the status field.
I've got a switch, which operates 2 guide-wires for my automower. The switch switches between these 2 wires, which opens and closes a pathway from my back lawn to my front lawn.
The path must be closed when the mower is actually mowing, and must be open when the mower is leaving og returning to the dock.
There is an entity "Leaving dock" - if status is no longer available, could I please have an entity for "Returning to dock"?

@Thomas55555
Copy link
Owner Author

Thomas55555 commented Sep 2, 2023

Returning to dock is one of the states of the vacuum entity. You can use this. Next time please start a discussion or something like that and don't comment closes PR. It's hard to track stuff here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants