Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build project with prev version of TS #147

Merged
merged 1 commit into from
May 27, 2023
Merged

fix: build project with prev version of TS #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/actions/install-node-modules/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@ name: Install Node Dependencies
description: Install dependencies using yarn
inputs:
node-version:
description: Node version to use
required: true
typescript-version:
required: true
description: TS version to use
default: "default"
runs:
using: composite
steps:
Expand Down Expand Up @@ -37,6 +39,6 @@ runs:
run: if [ '${{ steps.sync-node-modules-cache.outputs.cache-hit }}' != 'true' ]; then yarn install --immutable; fi
shell: bash

- name: Override TS with correct version
run: if [ '${{ steps.sync-node-modules-cache.outputs.cache-hit }}' != 'true' ]; then yarn add --dev typescript@${{ inputs.typescript-version }}; fi
- name: Override TS with specified version
run: if [ '${{ inputs.typescript-version }}' != 'default' ] && [ '${{ steps.sync-node-modules-cache.outputs.cache-hit }}' != 'true' ]; then yarn add --dev typescript@${{ inputs.typescript-version }}; fi
shell: bash
3 changes: 2 additions & 1 deletion .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ jobs:
strategy:
matrix:
node: [16, 18]
typescript: ["~4.5.5", "~4.6.4", "~4.7.4", "~4.8.3", "~4.9.5", "~5.0.4"]
typescript:
["default", "~4.6.4", "~4.7.4", "~4.8.3", "~4.9.5", "~5.0.4"]
name: Node ${{ matrix.node }} / TS ${{ matrix.typescript }}
steps:
- uses: actions/checkout@v3
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ jobs:
uses: ./.github/actions/install-node-modules
with:
node-version: 18
typescript-version: ~4.9.5

- name: Clear lib directory
run: rm -rf lib
Expand Down