configure.ac: make --disable-seccomp work #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first branch ("[action-if-given]") is taken even if --disable-seccomp
is passed. So, in that branch, check whether the user disabled it or not.
Without this, we'd get a failure when seccomp is detected but we want
to disable it:
```
./configure --disable-seccomp
[...]
checking for library containing clock_gettime... none required
configure: error: --enable-seccomp given but seccomp libraries not present
```
Signed-off-by: Sam James <sam@gentoo.org>
|
Ugh, well that's surprising to me. But perfectly documented. This also means that if seccomp libraries are present and configure is given Do you want to fix that, or should I merge this and do that party myself? |
ThomasHabets
added a commit
that referenced
this pull request
May 25, 2022
More complete fix than #51. Thanks thesamesam!
|
Fixed in 9da03da |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first branch ("[action-if-given]") is taken even if --disable-seccomp
is passed. So, in that branch, check whether the user disabled it or not.
Without this, we'd get a failure when seccomp is detected but we want
to disable it:
Signed-off-by: Sam James sam@gentoo.org