Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #28 File name change by forking and cloning #32

Closed
wants to merge 6 commits into from
Closed

Issue #28 File name change by forking and cloning #32

wants to merge 6 commits into from

Conversation

OnesQuared
Copy link
Contributor

No description provided.

@OnesQuared OnesQuared mentioned this pull request Apr 10, 2019
Closed
ThomasJayWilliams
ThomasJayWilliams requested changes Apr 10, 2019
View reviewed changes
Copy link
Owner

@ThomasJayWilliams ThomasJayWilliams left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, basically you can set core.ignorecase for existing repository. But now looks like you re-uploaded half of whole repository. But whatever, I will resolve the conflicts, it's fine.

File names have been changed, but not all. Some files still have to be renamed. Also, you still didn't renamed interfaces. We should not merge the unfinished issues.

@ThomasJayWilliams
Copy link
Owner

I guess I'll help you with that. That shouldn't be that hard.

@ThomasJayWilliams ThomasJayWilliams self-assigned this Apr 10, 2019
@OnesQuared
Copy link
Contributor Author

Sorry about that, seems like I'm causing some work load, but yea ended up doing a re upload as that was mostly suggested for the file name changes. Seems I've missed the interface whilst doing so, apologizes

@ThomasJayWilliams
Copy link
Owner

ThomasJayWilliams commented Apr 10, 2019 •
edited

Nah, it's fine. To be honest that was a bit more difficult than I though. Didn't expect that Git will be hating file renames like that. Anyway, you did good. I should've know about potential troubles.

Anyway, don't push yourself, I appreciate your help anyway.
Also, don't be ashamed to ask everything you want - I will try to help with anything.

@ThomasJayWilliams ThomasJayWilliams added cancelled Issue was cancelled improvement Existing code improvement labels Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasJayWilliams ThomasJayWilliams ThomasJayWilliams approved these changes

Assignees

@ThomasJayWilliams ThomasJayWilliams

Labels
cancelled Issue was cancelled improvement Existing code improvement
Projects
SDML.NET library
  
Cancelled
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OnesQuared @ThomasJayWilliams