Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Configure Digital Miner max radius, like in 1.12 and above #55

Closed
Desempregago opened this issue Nov 19, 2022 · 5 comments · Fixed by #65
Closed

[Suggestion] Configure Digital Miner max radius, like in 1.12 and above #55

Desempregago opened this issue Nov 19, 2022 · 5 comments · Fixed by #65

Comments

@Desempregago
Copy link

title explains itself

@Desempregago Desempregago added the TYPE: ENHANCEMENT New feature or request label Nov 19, 2022
@maggi373
Copy link
Member

maggi373 commented Nov 19, 2022

already had the idea myself on that but decided against it on increasing max distance.

@maggi373
Copy link
Member

were you specificly thinking of increasing the max radius of the miner or add a config allowing to set max allowed ranges?

@maggi373 maggi373 self-assigned this Nov 19, 2022
@maggi373 maggi373 added this to the 9.10.20 milestone Nov 19, 2022
@Desempregago
Copy link
Author

A config line to set maximum range, as seen in the 1.12+ versions

@maggi373
Copy link
Member

can do the config thing, but im probably not increasing the max range at 32. i might add comment in the config that 32+ is not supported range as a compromise.

@Desempregago
Copy link
Author

No need to increase the "vanilla" max range, I just asked for this to add parity to the 1.12 version, where you can set the maximum range up to 128 (IIRC)

@maggi373 maggi373 modified the milestones: 9.10.20, 9.10.21 Dec 18, 2022
maggi373 added a commit that referenced this issue Dec 22, 2022
max configurable range is 64
@maggi373 maggi373 linked a pull request Dec 22, 2022 that will close this issue
DrParadox7 added a commit that referenced this issue Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants