Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch Personal Chest dupe #143

Merged
merged 3 commits into from
Oct 15, 2023
Merged

Patch Personal Chest dupe #143

merged 3 commits into from
Oct 15, 2023

Conversation

DrParadox7
Copy link
Collaborator

Patches the Personal Chest dupe and adds a fail-safe config for modpacks to prevent the interaction all together.

@DrParadox7
Personal Chest Pocket Access Config
ea2e3da 
This controls access to Personal Chests from inventories
@DrParadox7
Fix #130
70a4376
@DrParadox7
Copy link
Collaborator Author

The way I have tackled this is by closing the GUI when the player switches slots after opening a Personal Chest.

@maggi373
Copy link
Member

The way I have tackled this is by closing the GUI when the player switches slots after opening a Personal Chest.

wont fix it but will make it harder, but still that bruh moment when i read that it does not close it atm.

@DrParadox7
Copy link
Collaborator Author

wont fix it but will make it harder

How exactly would you go around that?

@maggi373
Copy link
Member

wont fix it but will make it harder

How exactly would you go around that?

sorry mate, didnt check the commits, only saw what u wrote

@DrParadox7
Copy link
Collaborator Author

DrParadox7 commented Sep 25, 2023 •
edited
Loading

When you try to use a chest it will remember from which slot it was opened from.
From there on, the GUI will track your current active slot and should it ever be different than the initial slot it will close.

@maggi373 maggi373 self-requested a review October 15, 2023 14:39
@maggi373 maggi373 merged commit 6127ae6 into 1.7.10 Oct 15, 2023
1 check passed
@maggi373 maggi373 deleted the Personal-Dupe branch October 18, 2023 11:49
@maggi373
Copy link
Member

fixes #130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maggi373 maggi373 maggi373 approved these changes

Assignees

@maggi373 maggi373

Labels
MC: 1.7.10 PRIORITY: MED STATUS: FINISHED
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DrParadox7 @maggi373