New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix crash with ic2 #77 #78
Conversation
@@ -66,9 +66,14 @@ public static void init() { | |||
RecipeHandler.addEnrichmentChamberRecipe(StackUtils.size(ore, 1), new ItemStack(MekanismItems.OtherDust, 4, 1)); | |||
} | |||
|
|||
if (OreDictionary.getOres("itemRubber").size() > 0) { | |||
if (OreDictionary.getOres("itemRawRubber").size() > 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use !OreDictionary.getOres("itemRawRubber").isEmpty()
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well i'm lazy and didnt bothered to change that?, does the same anyways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feel free to change it, remember to test it aswell
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I'll eventually clean up the code in future commits
Could you also set
|
its not an oredict |
also final on osmiumcompat wont work due to that strings are added later in the code |
No description provided.