Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash with ic2 #77 #78

Merged
merged 2 commits into from Jan 15, 2023
Merged

fix crash with ic2 #77 #78

merged 2 commits into from Jan 15, 2023

Conversation

maggi373
Copy link
Member

No description provided.

@maggi373 maggi373 added this to the 9.10.24 milestone Jan 15, 2023
@maggi373 maggi373 self-assigned this Jan 15, 2023
@maggi373 maggi373 linked an issue Jan 15, 2023 that may be closed by this pull request
@@ -66,9 +66,14 @@ public static void init() {
RecipeHandler.addEnrichmentChamberRecipe(StackUtils.size(ore, 1), new ItemStack(MekanismItems.OtherDust, 4, 1));
}

if (OreDictionary.getOres("itemRubber").size() > 0) {
if (OreDictionary.getOres("itemRawRubber").size() > 0) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use !OreDictionary.getOres("itemRawRubber").isEmpty() instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well i'm lazy and didnt bothered to change that?, does the same anyways.

Copy link
Member Author

@maggi373 maggi373 Jan 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to change it, remember to test it aswell

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I'll eventually clean up the code in future commits

@DrParadox7
Copy link
Collaborator

Could you also set osmiumcompat to final and capitalize the "C" in compat in the code below:

private static final List<String> minorCompat = Arrays.asList("Nickel", "Aluminum");
private static final List<String> siliconcompat = Arrays.asList("itemSilicon", "silicon");
private static List<String> osmiumcompat = new ArrayList<>();

https://github.com/Thorfusion/Mekanism-1.7.10-Community-Edition/blob/ab77661778d0ed0af4a1ef99122070dca88f83d2/src/main/java/mekanism/common/integration/OreDictManager.java#L39

@maggi373
Copy link
Member Author

its not an oredict

@DrParadox7 DrParadox7 merged commit b4b0f70 into 1.7.10 Jan 15, 2023
@maggi373
Copy link
Member Author

Could you also set osmiumcompat to final and capitalize the "C" in compat in the code below:

private static final List<String> minorCompat = Arrays.asList("Nickel", "Aluminum");
private static final List<String> siliconcompat = Arrays.asList("itemSilicon", "silicon");
private static List<String> osmiumcompat = new ArrayList<>();

https://github.com/Thorfusion/Mekanism-1.7.10-Community-Edition/blob/ab77661778d0ed0af4a1ef99122070dca88f83d2/src/main/java/mekanism/common/integration/OreDictManager.java#L39

also final on osmiumcompat wont work due to that strings are added later in the code

@maggi373 maggi373 deleted the crash-with-only-ic2-#77 branch January 15, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: crash report
2 participants