Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Star map editor #216

Merged
merged 8 commits into from Feb 11, 2022
Merged

Star map editor #216

merged 8 commits into from Feb 11, 2022

Conversation

alexanderson1993
Copy link
Member

Description

Starts work on the star map editor. Includes the interstellar map, the ability to drag map objects around, and the ability to create and destroy objects.

The map can be accessed by navigating to "Plugin Config -> Thorium Default -> Edit -> Universe"

Related Issue

Closes #181
Closes #180
Closes #187
Refs #179
Refs #172

How do you know the changes work correctly?

Added a simple automated test.
Manual testing:

  • Navigate to the universe editor
  • Click the "Add" button in the menubar
  • Drag the solar system around
  • Refresh the browser - the solar system should be in the same place it was dragged to
  • Delete the solar system

Screenshots (if appropriate):

Types of changes

  • Docs Change (changes were only made to documentation)
  • Refactor (non-breaking change which improves code)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the built-in project documentation.
  • My change adds dependencies to this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@alexanderson1993
Copy link
Member Author

The pull request is so large because I copy/pasted a lot of code from Thorium Nova Prime.

@alexanderson1993
Copy link
Member Author

If anyone who reviews this would like me to pair with them while they review it, I'm happy to do that. Get in touch over Discord to schedule a time.

@alexanderson1993 alexanderson1993 merged commit 8b7c562 into develop Feb 11, 2022
@alexanderson1993 alexanderson1993 deleted the Star-Map-Editor branch February 11, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant