This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Move electron to Dev Dependencies #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using Electron-Packager I noticed my packaged app folder increasing dramatically after adding this module, so I started digging. Found that the electron package was getting bundled into the app even though I had electron listed in Dev Dependencies, digging further found it resided in this modules Dependencies, this was causing electron-packager to bundle it into the app, increasing the size by at least 132 MB. Simple fix though, just moved from Dependencies to Dev Dependencies and tested building and using the new version as a direct drop in replace on a couple apps I use this module in, and it works perfectly. Sizes are back to normal, so please consider my Pull-Request to help fellow users.
Side note: This is a fantastic module, thank you for your work!