Fix CI for Rocket diesel async example #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ELD
force-pushed
the
fix/diesel_async_examples
branch
3 times, most recently
from
6143c63
to
2217201
Compare
ELD
force-pushed
the
fix/diesel_async_examples
branch
24 times, most recently
from
be06854
to
6aff0e0
Compare
|
@ThouCheese Just marked this ready for review. It passes CI on my fork (https://github.com/ELD/Rocket/actions/runs/7354153657/attempts/1) and the successive runs show that |
ELD
force-pushed
the
fix/diesel_async_examples
branch
from
6aff0e0
to
1073921
Compare
|
Whoops, uncommented some pieces of the CI workflow. If it passes again, it's good to go! Check this job to know: |
- Start the preinstalled postgres service on the all executors
- Note: This will work until macos-13 becomes the default since it's
seemingly not installed on those runner images
- Create `rocket_runner` user
- Create the `epic_todo_database` DB
- Update SQL migrations to match Postgres dialect (different from SQLite
or MySQL)
- Update user/pass configuration for Postgres user/db
ELD
force-pushed
the
fix/diesel_async_examples
branch
from
1073921
to
a984379
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for the upstream PR for enabling Postgres for diesel-async. There are several changes that this PR introduces to the CI configuration to ensure this works:
vcpkgcaching from a static zip to GHAactions/cache(this can be reverted to a static zip, but it doesn't work to download the zip, upgradelibpq, and roll forward; we need to re-vendor the zip cache)