-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross-platform projects and NuGet (issues #2 and #5) #6
Conversation
…Core root project
Oh yeahhh!!! Thank you very much!! you are awasome! |
Glad you like it! Can you test the NuGet dependencies (which I'm using, but a second look is always helpful)? They should be drop-in replacements for binary builds, unless you're relying on things that broke between MonoGame 3.2 and 3.3. |
…le into feature/shared-projects
…t tested MacOS and Linux yet but they seem to compile
Everything work very fine!!! |
The Linux stuff works in this PR. Still fighting with janky Xamarin Studio/MonoMac stuff. |
@tgiachi: Can you elaborate on what you've tested? Did it drop into a current project or something? |
…ramework dependency. UNTESTED ON LINUX
Hi @eropple!, |
VERY AWESOME. I'll get working on vetting this all and merging it in. |
Cool. Actually testing the MacOS and Linux NuGet packages will be a little bit tricky, but I think for the most part it should all work. I don't actually need those yet, so I haven't gotten to that yet. |
I've also restructured the editor to support multi platform also. |
Badass. Any issues or red flags in doing so? On Wed, Apr 29, 2015 at 6:22 PM, Andy (adegeo) notifications@github.com
Ed Ropple Twitter: https://twitter.com/edropple |
Nope, just new to playing with shared projects, so used yours changes to sadconsole as a guide. 😄 Should I move the modify the nuget packages and make them "official?" I'm unsure of the normal workflow, is it common to have them maintained by a 3rd party (yourself) or no? I don't "need to be in control" so I don't mind having you do it if you're up to taking on the responsibility. |
You're welcome to if you'd like--it's not difficult. I don't mind doing it On Wed, Apr 29, 2015 at 9:06 PM, Andy (adegeo) notifications@github.com
Ed Ropple Twitter: https://twitter.com/edropple |
If you want to share admin that would be fine and you can do it as long as you like then just hand it back to me. |
One thing to add to the description of the libraries would be to add these keywords to aid in people who search for something: ascii, ansi, and console. |
(I know, it's a minor sin to couple issues in a pull request, but tackling both of these at the same time was easier.)
I've pulled apart the various
SadConsole
projects into two projects each: a VS2013/2015 shared project,SadConsole.PROJNAME
, that contains code, andSadConsole.Platforms.Windows.PROJNAME
, which contains the (platform-specific) MonoGame dependencies. I've tested these against each other and the starter project, which seems to work fine, but I haven't tried it against SadConsoleEditor so testing against that might be wise.An important thing to note: while VS2013 (patched) or VS2015 are necessary to edit this solution, the assemblies generated and in NuGet work with any version of Visual Studio that can handle .NET 4.5.
As a side effect of this, I've broken some contracts, and as such I've bumped the version number to 2.0.
SadConsole.XNA.sln
, it can all be done in a single solution.)EdCanHack.
prefix because I've published this branch under my own namespace (and indicated that it's unofficial) for testing and for my own use.