Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-platform projects and NuGet (issues #2 and #5) #6

Merged
merged 24 commits into from
Apr 27, 2015
Merged

Cross-platform projects and NuGet (issues #2 and #5) #6

merged 24 commits into from
Apr 27, 2015

Conversation

eropple
Copy link
Contributor

@eropple eropple commented Apr 26, 2015

(I know, it's a minor sin to couple issues in a pull request, but tackling both of these at the same time was easier.)

I've pulled apart the various SadConsole projects into two projects each: a VS2013/2015 shared project, SadConsole.PROJNAME, that contains code, and SadConsole.Platforms.Windows.PROJNAME, which contains the (platform-specific) MonoGame dependencies. I've tested these against each other and the starter project, which seems to work fine, but I haven't tried it against SadConsoleEditor so testing against that might be wise.

An important thing to note: while VS2013 (patched) or VS2015 are necessary to edit this solution, the assemblies generated and in NuGet work with any version of Visual Studio that can handle .NET 4.5.

As a side effect of this, I've broken some contracts, and as such I've bumped the version number to 2.0.

  • I removed XNA 4.0 support. This could be re-added by adding shared projects that target XNA, but since I don't need such projects I didn't go that route. (The upside of this design is that the project doesn't need a SadConsole.XNA.sln, it can all be done in a single solution.)
  • I configured each project to use NuGet to pull MonoGame dependencies and to make using this library in NuGet environments feasible.
  • Because of this, I bumped the MonoGame version to 3.3 (current NuGet head), which resulted in a minor incompatibility (fixed in this branch) in the starter project.
  • I removed the Binaries and Builds directories because they're not necessary anymore.
  • I added nuspec files for each Windows project, currently pointing with an EdCanHack. prefix because I've published this branch under my own namespace (and indicated that it's unofficial) for testing and for my own use.

This was referenced Apr 26, 2015
@tgiachi
Copy link

tgiachi commented Apr 26, 2015

Oh yeahhh!!! Thank you very much!! you are awasome!

@eropple
Copy link
Contributor Author

eropple commented Apr 26, 2015

Glad you like it! Can you test the NuGet dependencies (which I'm using, but a second look is always helpful)? They should be drop-in replacements for binary builds, unless you're relying on things that broke between MonoGame 3.2 and 3.3.

https://www.nuget.org/packages?q=sadconsole

@tgiachi
Copy link

tgiachi commented Apr 26, 2015

Everything work very fine!!!

@eropple
Copy link
Contributor Author

eropple commented Apr 26, 2015

The Linux stuff works in this PR. Still fighting with janky Xamarin Studio/MonoMac stuff.

@eropple
Copy link
Contributor Author

eropple commented Apr 26, 2015

@tgiachi: Can you elaborate on what you've tested? Did it drop into a current project or something?

@eropple
Copy link
Contributor Author

eropple commented Apr 26, 2015

screen shot 2015-04-26 at 2 49 56 pm
screen shot 2015-04-26 at 2 57 19 pm
screenshot - 04262015 - 03 00 51 pm

@tgiachi
Copy link

tgiachi commented Apr 27, 2015

Hi @eropple!,
I've made simple project with Windows 8. Also i've tested on OSX, with last mono version, everything works fine!

@Thraka
Copy link
Owner

Thraka commented Apr 27, 2015

VERY AWESOME. I'll get working on vetting this all and merging it in.

Thraka added a commit that referenced this pull request Apr 27, 2015
Cross-platform projects and NuGet (issues #2 and #5)
@Thraka Thraka merged commit 88ea91e into Thraka:master Apr 27, 2015
@eropple
Copy link
Contributor Author

eropple commented Apr 27, 2015

Cool. Actually testing the MacOS and Linux NuGet packages will be a little bit tricky, but I think for the most part it should all work. I don't actually need those yet, so I haven't gotten to that yet.

@Thraka
Copy link
Owner

Thraka commented Apr 29, 2015

I've also restructured the editor to support multi platform also.
https://github.com/Thraka/SadConsoleEditor

@eropple
Copy link
Contributor Author

eropple commented Apr 30, 2015

Badass. Any issues or red flags in doing so?

On Wed, Apr 29, 2015 at 6:22 PM, Andy (adegeo) notifications@github.com
wrote:

I've also restructured the editor to support multi platform also.
https://github.com/Thraka/SadConsoleEditor


Reply to this email directly or view it on GitHub
#6 (comment).

Ed Ropple
http://edcanhack.com

Twitter: https://twitter.com/edropple
Github: https://github.com/eropple

@Thraka
Copy link
Owner

Thraka commented Apr 30, 2015

Nope, just new to playing with shared projects, so used yours changes to sadconsole as a guide. 😄

Should I move the modify the nuget packages and make them "official?" I'm unsure of the normal workflow, is it common to have them maintained by a 3rd party (yourself) or no? I don't "need to be in control" so I don't mind having you do it if you're up to taking on the responsibility.

@eropple
Copy link
Contributor Author

eropple commented Apr 30, 2015

You're welcome to if you'd like--it's not difficult. I don't mind doing it
if you'd rather not. (I'll probably need to maintain an unofficial package
set if I'm going to fight with MacOS packages and such.) There may be a way
to share package admin, I've never looked.

On Wed, Apr 29, 2015 at 9:06 PM, Andy (adegeo) notifications@github.com
wrote:

Nope, just new to playing with shared projects, so used yours changes to
sadconsole as a guide. [image: 😄]

Should I move the modify the nuget packages and make them "official?" I'm
unsure of the normal workflow, is it common to have them maintained by a
3rd party (yourself) or no? I don't "need to be in control" so I don't mind
having you do it if you're up to taking on the responsibility.


Reply to this email directly or view it on GitHub
#6 (comment).

Ed Ropple
http://edcanhack.com

Twitter: https://twitter.com/edropple
Github: https://github.com/eropple

@Thraka
Copy link
Owner

Thraka commented Apr 30, 2015

If you want to share admin that would be fine and you can do it as long as you like then just hand it back to me.

@Thraka
Copy link
Owner

Thraka commented Apr 30, 2015

One thing to add to the description of the libraries would be to add these keywords to aid in people who search for something: ascii, ansi, and console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants