docker: fix copy server/static files #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thx. :) noticed the same in parallel and adjusted the Dockerfile already (build is in progress) |
|
... will then use the version that is smaller (probably the one with just one COPY command) |
z00mi
pushed a commit
to z00mi/threagile
that referenced
this pull request
Apr 23, 2024
docker: fix copy server/static files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37 .
Attempting to copy
/app/serverdoes not createserverfolder, but instead it copies its content (static).In order to keep same simple copy instruction, copy as many files into a previous stage (with required owner), then finally copy everything over final image.