Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Rename the package from @thream/socketio-jwt to socket.io-jwt #94

Closed
theoludwig opened this issue Apr 22, 2021 · 1 comment
Closed

[Improvement] Rename the package from @thream/socketio-jwt to socket.io-jwt #94

theoludwig opened this issue Apr 22, 2021 · 1 comment
Assignees
@theoludwig
Labels
improvement Improve structure/format/performance/refactor/tests of the code

Comments

@theoludwig
Copy link
Member

theoludwig commented Apr 22, 2021 •
edited
Loading

Proposal

Instead to name our package @thream/socketio-jwt, we could rename it socket.io-jwt, shorter and easier name + nearly the same name as the original package.
Once done, we should deprecate the old one @thream/socketio-jwt.
Hopefully, once we want to do it the npm will still be available, currently it is: https://www.npmjs.com/package/socket.io-jwt

Note: It is a BREAKING CHANGE.
@theoludwig theoludwig added the improvement Improve structure/format/performance/refactor/tests of the code label Apr 22, 2021
@theoludwig theoludwig added this to the 3.0.0 milestone Apr 22, 2021
@theoludwig theoludwig self-assigned this Apr 22, 2021
@theoludwig
Copy link
Member Author

Not anymore relevant, it is a useless BREAKING CHANGE for now.
We'll maybe consider it later.

@theoludwig theoludwig removed this from the v3.0.0 milestone Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theoludwig theoludwig

Labels
improvement Improve structure/format/performance/refactor/tests of the code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@theoludwig