Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade backoff library #109

Merged
merged 1 commit into from
Aug 8, 2019
Merged

Conversation

sagikazarmark
Copy link
Contributor

Unfortunately v2 of the used backoff library violates the implementation of Go Modules.

I noticed that during testing go1.13beta1 and GOPROXY:

curl https://proxy.golang.org/github.com/cenkalti/backoff/@v/v2.2.0+incompatible.info
not found: github.com/cenkalti/backoff@v2.2.0+incompatible: invalid version: +incompatible suffix not allowed: module contains a go.mod file, so semantic import versioning is required

Here is an issue discussing that: #76

So I upgraded the backoff library.

Unfortunately, anyone using a go proxy suffers from this with RC1:
https://circleci.com/gh/goph/logur/75

@roblaszczak roblaszczak merged commit c77498c into ThreeDotsLabs:master Aug 8, 2019
@sagikazarmark sagikazarmark deleted the backoff branch August 8, 2019 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants