Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update simple-app example #120

Merged
merged 28 commits into from
Sep 7, 2019
Merged

Update simple-app example #120

merged 28 commits into from
Sep 7, 2019

Conversation

m110
Copy link
Member

@m110 m110 commented Aug 31, 2019

  • Add "basic" examples category and move your-first-app there (no changes in code).
  • Rename simple-app to realtime-feed and move it to the basic category.
  • Add some background in the README.
  • Usual cosmetic style updates, grammar fixes and comments.
  • Added "exercises" section to the README, new idea that I think might be also added in other examples. They are usually kept simple to avoid clutter, but can be easily extended.

@m110 m110 changed the base branch from update-sql-docs to master September 1, 2019 11:01
@m110 m110 marked this pull request as ready for review September 1, 2019 11:01
m110 and others added 5 commits September 1, 2019 13:03
@m110 @roblaszczak
Update _examples/basic/2-realtime-feed/consumer/main.go
54542d3 
Co-Authored-By: Robert Laszczak <roblaszczak@gmail.com>
@m110 @roblaszczak
Update _examples/basic/2-realtime-feed/producer/main.go
594f84d 
Co-Authored-By: Robert Laszczak <roblaszczak@gmail.com>
@m110
Merge branch 'master' into update-simple-app
276f55f
@m110
Update middlewares order
3b1f8a1
@maclav3
Use chan *message.Message to simplify producing messages (#121)
68a6b4e 
* Use chan *message.Message to simplify producing messages
* Make 2-realtime-feed producer produce messages indefinitely
@m110 @roblaszczak
Update _examples/basic/2-realtime-feed/consumer/main.go
f702458 
Co-Authored-By: Robert Laszczak <roblaszczak@gmail.com>
@m110 m110 merged commit 03ab332 into master Sep 7, 2019
@roblaszczak roblaszczak deleted the update-simple-app branch September 11, 2019 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roblaszczak roblaszczak roblaszczak approved these changes

@maclav3 maclav3 maclav3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@m110 @roblaszczak @maclav3