Create middleware duplicating messages #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m110
reviewed
Oct 28, 2019
| func Duplicator(h message.HandlerFunc) message.HandlerFunc { | ||
| return func(msg *message.Message) ([]*message.Message, error) { | ||
| events, err := h(msg) | ||
| _, _ = h(msg) |
There was a problem hiding this comment.
Handling of these errors is an interesting case. If we'd like to make sure that our system is idempotent, we should probably check if the second handler didn't return an error.
Also worth considering if other middlewares won't cause some weird issues.
roblaszczak
reviewed
Nov 1, 2019
roblaszczak
reviewed
Nov 12, 2019
roblaszczak
reviewed
Nov 12, 2019
| return nil, firstErr | ||
| } | ||
|
|
||
| _, secondErr := h(msg) |
There was a problem hiding this comment.
I was thinking about it for a while, and probably we want to append it to producedMessages, eventually we can add config for this decorator (like in Retry) or separated decorator (like in PoisonQueue or PoisonQueueWithFilter).
There was a problem hiding this comment.
Fix c8baf8a
Co-Authored-By: Robert Laszczak <eventched@gmail.com>
…0/watermill into duplicating-middleware
roblaszczak
approved these changes
Nov 14, 2019
m110
approved these changes
Nov 14, 2019
|
@roblaszczak @m110 Could you merge the PR? I don't have write access to the repository |
|
@0michalsokolowski0 Merged, thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving #131