New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mill googlecloud subscription ls
#220
Conversation
} | ||
|
||
func printSubscriptionInfo(name string, config pubsub.SubscriptionConfig) error { | ||
b, err := yaml.Marshal(subscriptionConfig{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why YAML actually? maybe some ASCII table would be a bit better? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chose YAML because it's more readable than JSON.
asciitable should be OK as well.
It will be adding a new dependency, though. We already depend on yaml for some reason.
Ok, LGTM. Thanks for the contribution 🍻 |
* Initialize subscribers for each consumer group (ThreeDotsLabs#225) Co-authored-by: Lucas Bremgartner <lucas@elblox.com> * Proper Message nil m.ack handling (ThreeDotsLabs#227) when Message.Ack invoke in bad situation, maybe better. * Added exactly-once delivery example (ThreeDotsLabs#228) * Added exactly-once delivery example * added README for example * readme cosmetics * readme cosmetics * readme cosmetics * Update README.md * update deps * README cosmetics Co-authored-by: Miłosz Smółka <milosz.smolka@gmail.com> * Added new example to README.md * Fix netlify build (ThreeDotsLabs#236) * fix netlify build * fix hugo version * fix build * Added Discord server link * Add watermill-firestore to the list of Pub/Subs (ThreeDotsLabs#234) * Add watermill-firestore to the list of Pub/Subs * Add last_line_equals and cleanup the docs * Consumer groups are not supported * Add some context to why this pub/sub is useful * Return the handler instance created within AddNoPublisherHandler (ThreeDotsLabs#229) * Add `mill googlecloud subscription ls` (ThreeDotsLabs#220) * Add `mill googlecloud subscription ls` * fix * sort imports * Remove unnecessary change * Update README * update deps * Update deps and Go (ThreeDotsLabs#245) * Fix master build due deps error * update deps * update Go in build image * update all Go versions * Stress tests bugfix * Added dynamic stress test config * Mark consumer groups as supported (ThreeDotsLabs#246) Consumer groups are currently marked as supported here https://github.com/ThreeDotsLabs/watermill-firestore/blob/master/pkg/firestore/pubsub_test.go#L53 Co-authored-by: Lucas Bremgartner <breml@users.noreply.github.com> Co-authored-by: Lucas Bremgartner <lucas@elblox.com> Co-authored-by: Ding <oxbambooxo@gmail.com> Co-authored-by: Robert Laszczak <roblaszczak@gmail.com> Co-authored-by: Miłosz Smółka <milosz.smolka@gmail.com> Co-authored-by: Filip Borkiewicz <boreq@0x46.net> Co-authored-by: Trevor Foster <trevor.foster@hotmail.ca> Co-authored-by: Maciej Bratek <maclav3@gmail.com> Co-authored-by: Robert Laszczak <robert.laszczak@karhoo.com>
Adds a command
mill googlecloud subscription ls
that lists googlecloud subscriptions.A topic may be given to filter the results.