Changes to Pubsub Test for ExactlyOnce #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* when testing with NATS jetstream the broker will not allow message republication with the same message ID
|
With these couple changes I am able to get a basic exactly once test running with a WIP NATS jetstream client - it makes sense to me why the changes would be needed for the NATs implementation but I am not sure if this coverage would be needed for other pubsubs that support exactly once, may need to find a different way to test. |
|
LGTM, thanks for the contribution! @AlexCuse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed one bad feature check (skipping if Persistent enabled, though message indicates ExactlyOnce intended).
Also added another to skip TestMessageCtx - this can also be addressed by calling publish the second time with a new message ID but I am not sure if that would invalidate the test in other situation?