Add CQRS marshalers #78
Conversation
components/cqrs/marshaler_name.go
Outdated
| return m.marshaler().Name(v) | ||
| } | ||
|
|
||
| func (m *NameMarshaler) NameFromMessage(msg *message.Message) string { |
There was a problem hiding this comment.
hmm, I'm not sure if the marshaller should have this method. Maybe I'm losing some context here but for me, it should go to message.Message.
There was a problem hiding this comment.
It's part of the CommandEventMarshaler interface
| } | ||
|
|
||
| func (m *StructNameMarshaler) Name(v interface{}) string { | ||
| segments := strings.Split(fmt.Sprintf("%T", v), ".") |
There was a problem hiding this comment.
if v is pointer it will have * prefix, do we want to remove it? 😉
There was a problem hiding this comment.
I think so, but it gets removed: https://play.golang.org/p/97dR-e246vB
| // It wraps another marshaler which takes care of the message serialization/deserialization. | ||
| // If none provided, it falls back to JSON marshaler. | ||
| type StructNameMarshaler struct { | ||
| Marshaler CommandEventMarshaler |
There was a problem hiding this comment.
after some thinking, maybe it will be a better idea to not add it as an implementation of Marshaler interface, but like function and add an extra attribute for existing marshallers, like:
type JSONMarshaler struct {
NewUUID func() string
GenerateName func(v interface{}) string
}
with default GenerateName = ObjectName.
In that case, you may rename object.go to something more meaningful, and keep all names generations methods like functions
In that case, the implementations are still more about output format, and naming is decoupled.
What do you think? :)
There was a problem hiding this comment.
Sounds good to me. I will update the PR soon
|
|
||
| // StructName name returns struct name in format [type name]. | ||
| // It ignores if the value is a pointer or not. | ||
| func StructName(v interface{}) string { |
There was a problem hiding this comment.
maybe ObjectNameWithoutPackage? it is pretty long, but explicit :)
There was a problem hiding this comment.
I was rather thinking about renaming ObjectName to FullyQualifiedStructName and leave this as is, but ObjectNameWithoutPackage works as well.
There was a problem hiding this comment.
ok, like I like the idea of FullyQualifiedStructName :)
components/cqrs/name.go
Outdated
| // Name() string | ||
| // } | ||
| // It ignores if the value is a pointer or not. | ||
| func MessageName(fallback func(v interface{}) string) func(v interface{}) string { |
There was a problem hiding this comment.
what do you think about NamedObject?
There was a problem hiding this comment.
Following the pattern I suggested above, this could be NamedStruct, but if we stick with object, NamedObject works.
|
🎉 Thanks @roblaszczak |
No description provided.