added context cancelling support #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Jun 1, 2019
message/router/middleware/retry.go
Outdated
| return events, nil | ||
| } | ||
|
|
||
| elapsedTime := time.Now().Sub(startTime) |
There was a problem hiding this comment.
S1012: should use time.Since instead of time.Now().Sub (from gosimple)
|
|
||
| startTime := time.Now() | ||
| _, _ = h(message.NewMessage("1", nil)) | ||
| timeElapsed := time.Now().Sub(startTime) |
There was a problem hiding this comment.
S1012: should use time.Since instead of time.Now().Sub (from gosimple)
maclav3
approved these changes
Jun 1, 2019
m110
reviewed
Jun 1, 2019
message/router/middleware/retry.go
Outdated
|
|
||
| elapsedTime := time.Now().Sub(startTime) | ||
|
|
||
| if r.shouldRetry(retries, elapsedTime) { |
There was a problem hiding this comment.
How about changing this to avoid long nesting?
if !r.shouldRetry(...) {
return
}There was a problem hiding this comment.
Or maybe break then and return at the end of the function.
m110
approved these changes
Jun 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.