Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ocelot not depending on .net standard #1136

Closed
TheElectricCo opened this issue Feb 18, 2020 · 4 comments
Closed

Ocelot not depending on .net standard #1136

TheElectricCo opened this issue Feb 18, 2020 · 4 comments
Assignees
Labels
documentation Needs a documentation update

Comments

@TheElectricCo
Copy link

Expected Behavior / New Feature

As stated in the ReadMe, Ocelot depends on .net standard 2.0 and should be usable with full .net framework

Actual Behavior / Motivation for New Feature

Nuget states that Ocelot 14.0.9 depends on .net core 3.1

image

@jmezach
Copy link
Contributor

jmezach commented Feb 18, 2020

This was changed as part of the .NET Core 3.0 upgrade (see #1025). I remember we discussed this at the time and decided that it was fine to switch to using netcoreapp3.1 and figured that folks who want to keep using it on older versions of .NET should stick with the older versions of Ocelot.

We should at least update the documentation to point this out, but I'm wondering if you have a particular use case in mind that requires you to have Ocelot target .NET Standard 2.0?

@TheElectricCo
Copy link
Author

TheElectricCo commented Feb 18, 2020

Hi @jmezach,

thanks for the reply! I wasn't aware of the previous discussion (#1025)

No, I don't have an actual use case, but I was following the MS Microservices architecture paper and it also stated that Ocelot targets .net standard 2.0 and you could use it with .net core or full .net. I was experimenting with a asp.net core application targeting the full .net framework (net48), noticing that my Ocelot package was complaining.

meanwhile I changed the package to netcoreapp 3.1 and everything works as a charm, thank you for this fine piece of software!

@jmezach
Copy link
Contributor

jmezach commented Feb 18, 2020

I see. Not sure what we can about the Microsoft docs to be honest, I'll have to check with @TomPallister. And its really him you should be thanking, since he wrote most of the code here.

We'll update the README here though so that folks know that we do not target .NET Standard anymore ;)

@jmezach jmezach self-assigned this Feb 18, 2020
@jmezach jmezach added the documentation Needs a documentation update label Feb 19, 2020
@raman-m
Copy link
Member

raman-m commented Mar 23, 2024

Not an issue!
Fixed by #1025

@raman-m raman-m closed this as completed Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Needs a documentation update
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants