update .net core 3.0 RTM

[geffzhang]

Fixes / New Feature #
Fix #1001 and update .net core 3.0 RTM

[catcherwong]

The .NET SDK version of both continuous-integrations is 2.2.x.

Maybe we should update the configuration of CI as well.

[catcherwong]

The value of osx_image should update to xcode9.4 or above.

[Varorbc]

The update of this package should be here

Ocelot/Directory.Build.props

Line 14 in c8a2144

<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0-beta2-18618-05" PrivateAssets="All"/>

[dennismdejong]

Please retry the AppVeyor build as .Net Core 3.0 is available right now and wasen't at the moment the build was queued

[jmezach]

@Leandropintogit Interesting discussion which I think demonstrates the exact behaviour I'm seeing as well. Doesn't look like it's likely to be changed back though, so I think Ocelot will need to react to this change.

As for my changes, I think they actually make sense. With the original implementation it seems that the ConsulFileConfigurationRepository is trying to use the IInternalConfiguration that it is itself responsible for retrieving from Consul. That basically leads to a bit of a chicken and egg problem. With my changes the ConsulFileConfigurationRepository relies on a piece of statically available configuration which isn't very likely to change once Ocelot has started. In fact, that is exactly what the documentation suggest you do; set the service discovery provider information in ocelot.json and the rest of the configuration will be read from there.

Still interested to hear what @TomPallister and @thiagoloureiro think about my change though ;).

[Leandropintogit]

After digging in some more I think I have a fairly simple solution to this issue, but I'm not entirely sure that it's the correct way to fix the issue. It works fine for my use case though. See my commit jmezach@a0ff389 to see what I've changed @thiagoloureiro @TomPallister

@jmezach
Good job. I just changed the order of assignment of the _configurationKey variable

var serviceDiscoveryProvider = fileConfiguration.Value.GlobalConfiguration.ServiceDiscoveryProvider;
_configurationKey = serviceDiscoveryProvider.ConfigurationKey ?? "InternalConfiguration";

        `var config = new ConsulRegistryConfiguration(serviceDiscoveryProvider.Host,
            serviceDiscoveryProvider.Port, _configurationKey, serviceDiscoveryProvider.Token);`

        `_consul = factory.Get(config);`

[Hbib-drif]

Great work guys , is there an update or the issue is still not fixed ?

[jesnasali]

Is there an update?

[jmezach]

I made another pull request (geffzhang/Ocelot#11) with my proposed fix as described earlier, including the fix in ordering of variable assignment that @Leandropintogit mentioned. Let me know if you want to take it ;).

[jmezach]

Whoops, forgot to fix the tests it seems. Will fix that ;).

[pranavpatil19]

is there an issue or the issue is still not fixed ?

[jmezach]

@pranavpatil19 Well, if you're not using Consul as your configuration store there's no issue, at least not that I'm aware off. If you are, then you'll want to hold off on moving to .NET Core 3.0 for now ;).

[LGinC]

I need a new nuget package to fix json issue

[jmezach]

@geffzhang I made another PR (geffzhang/Ocelot#12) with the fix for the broken tests.

[geffzhang]

@jmezach I've merged your pr， the error： [/home/travis/build/ThreeMammals/Ocelot/test/Ocelot.UnitTests/Ocelot.UnitTests.csproj]
Consul/ConsulFileConfigurationRepositoryTests.cs(58,59): error CS1503: Argument 1: cannot convert from 'Ocelot.Cache.IOcelotCache<Ocelot.Configuration.File.FileConfiguration>' to 'Microsoft.Extensions.Options.IOptions<Ocelot.Configuration.File.FileConfiguration>' [/home/travis/build/ThreeMammals/Ocelot/test/Ocelot.UnitTests/Ocelot.UnitTests.csproj]
Consul/ConsulFileConfigurationRepositoryTests.cs(58,74): error CS1503: Argument 2: cannot convert from 'Ocelot.Configuration.Repository.IInternalConfigurationRepository' to 'Ocelot.Cache.IOcelotCache<Ocelot.Configuration.File.FileConfiguration>' [/home/travis/build/ThreeMammals/Ocelot/test/Ocelot.UnitTests/Ocelot.UnitTests.csproj]
Consul/ConsulFileConfigurationRepositoryTests.cs(146,59): error CS1503: Argument 1: cannot convert from 'Ocelot.Cache.IOcelotCache<Ocelot.Configuration.File.FileConfiguration>' to 'Microsoft.Extensions.Options.IOptions<Ocelot.Configuration.File.FileConfiguration>' [/home/travis/build/ThreeMammals/Ocelot/test/Ocelot.UnitTests/Ocelot.UnitTests.csproj]
Consul/ConsulFileConfigurationRepositoryTests.cs(146,74): error CS1503: Argument 2: cannot convert from 'Ocelot.Configuration.Repository.IInternalConfigurationRepository' to 'Ocelot.Cache.IOcelotCache<Ocelot.Configuration.File.FileConfiguration>' [/home/travis/build/ThreeMammals/Ocelot/test/Ocelot.UnitTests/Ocelot.UnitTests.csproj]
1666 Warning(s)

[jmezach]

Turned out there were some acceptance tests in there as well which were failing because of a condition I missed. Thank god for tests ;). I created yet another PR (geffzhang#13) which should fix those tests as well.

@geffzhang Not sure where you got that error from. I'm guessing you saw older build results or something. I've seen that happen before as well.

[geffzhang]

@thiagoloureiro Release a new version of the nuget package

[pranavpatil19]

@jmezach @geffzhang is there an issue ? waiting for new stable release

[thangchung]

@thiagoloureiro Release a new version of the nuget package

We're still waiting for this release for a long time :(

[jmezach]

@pranavpatil19 No issues as far as I know, but we're not able to get this merged. I think we need someone from ThreeMammals to merge this, which seems to include @AbolfazlRajabpour, @anktsrkr, @binarymash, @briansantura, @jps, @philproctor, @thiagoloureiro and @TomPallister.

[mehranzand]

When can I get package through the nuget?

[Mo-ha-mmed]

Hello guys.
Is there an alternative to ocelot for .net core 3.0

[TomPallister]

I will get a release out this morning before I go to work!

[saadshams]

updated nuget package please?

[jmezach]

@saadshams New version is already available on NuGet (version 13.8.0) with compatibility for .NET Core 3.0. I have already successfully upgraded my project to 3.0 which uses Ocelot.