Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable default timeout for HttpMessageInvoker #1314

Open
danielcandea opened this issue Aug 17, 2020 · 5 comments · May be fixed by #2073
Open

Configurable default timeout for HttpMessageInvoker #1314

danielcandea opened this issue Aug 17, 2020 · 5 comments · May be fixed by #2073
Labels
Configuration Ocelot feature: Configuration feature A new feature QoS Ocelot feature: Quality of Service Routing Ocelot feature: Routing small effort Likely less than a day of development effort. Spring'24 Spring 2024 release
Milestone

Comments

@danielcandea
Copy link

danielcandea commented Aug 17, 2020

New Feature

Enable configurability of the default timeout for MessageInvokerPool.
Functions of new properties:

  • A global timeout in the FileGlobalConfiguration section would set a default timeout value for all routes, applicable to both QoS and non-QoS scenarios.
  • A local, route-level timeout in FileRoute settings would take precedence, allowing for the overriding of the global default value.

Motivation for New Feature

Setting a custom default global timeout is simpler than configuring QoS settings for each handler, particularly when multiple handlers are defined.

Notes

There is an undocumented Timeout property at the route level that is not implemented:

public int Timeout { get; set; }

@raman-m raman-m added the QoS Ocelot feature: Quality of Service label Oct 25, 2023
@raman-m raman-m added Configuration Ocelot feature: Configuration Routing Ocelot feature: Routing feature A new feature small effort Likely less than a day of development effort. Spring'24 Spring 2024 release labels Mar 27, 2024
@raman-m raman-m added this to the March-April'24 milestone Mar 27, 2024
@raman-m raman-m added Summer'24 Summer 2024 release and removed Spring'24 Spring 2024 release labels May 9, 2024
@raman-m raman-m modified the milestones: March-April'24, May-June'24 May 9, 2024
@raman-m
Copy link
Member

raman-m commented May 9, 2024

@RaynaldM Useful?
Could your team develop this feature please?

The issue has been shifted to the current monthly May-June'24 release to provide your team with ample time for development.

@raman-m
Copy link
Member

raman-m commented May 9, 2024

@danielcandea Do you have intention to contribute?

@danielcandea
Copy link
Author

@raman-m I'm not in the team using Ocelot anymore, for a long time now. The file I mentioned doesn't exist anymore, I would need to get familiar with the code again, after almost four years.
I can't commit time at the moment but would love to give this a go at some point in in the future. If this isn't ok for you, I'm happy to close this.

@raman-m
Copy link
Member

raman-m commented May 11, 2024

@danielcandea Thanks for the feedback!
This issue will not be closed. We will develop it within the current May-June'24 milestone.

@RaynaldM
Copy link
Collaborator

RaynaldM commented May 13, 2024

@raman-m commented on May 9:

@RaynaldM Useful?

It is

@hogwartsdeveloper hogwartsdeveloper linked a pull request May 26, 2024 that will close this issue
@raman-m raman-m changed the title Make default timeout for HttpClientBuilder configurable Configurable default timeout for HttpMessageInvoker May 29, 2024
@raman-m raman-m added Spring'24 Spring 2024 release and removed Summer'24 Summer 2024 release labels May 29, 2024
@raman-m raman-m modified the milestones: Summer'24, Spring'24 May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Configuration Ocelot feature: Configuration feature A new feature QoS Ocelot feature: Quality of Service Routing Ocelot feature: Routing small effort Likely less than a day of development effort. Spring'24 Spring 2024 release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants