Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ocelot overides System.Text.Json parser and uses Newtonsoft #1351

Closed
neetra opened this issue Oct 8, 2020 · 4 comments · Fixed by #1655
Closed

Ocelot overides System.Text.Json parser and uses Newtonsoft #1351

neetra opened this issue Oct 8, 2020 · 4 comments · Fixed by #1655
Assignees
@neetra
Labels
merged Issue has been merged to dev and is waiting for the next release proposal Proposal for a new functionality in Ocelot

Comments

@neetra
Copy link

neetra commented Oct 8, 2020

Expected Behavior / New Feature

When try using ocelot, Newtonsoft parser is used, but i want to use System.text.json

Actual Behavior / Motivation for New Feature

Steps to Reproduce the Problem

Specifications

  • Version:
  • Platform:
  • Subsystem:
@marciocrmendes
Copy link

It happens to me too. But when I try to use Newtonsoft parser instead, doesn't work either returning to me always the default value.

@neetra
Copy link
Author

neetra commented Jan 23, 2021

@Marciocristian I found this fix by adding system.text.json input and output formatters to Startup.cs in asp net core

@neetra neetra closed this as completed Jan 23, 2021
@marciocrmendes
Copy link

@Marciocristian I found this fix by adding system.text.json input and output formatters to Startup.cs in asp net core

ty

@raman-m raman-m added the proposal Proposal for a new functionality in Ocelot label Sep 21, 2023
@raman-m raman-m linked a pull request Sep 21, 2023 that will close this issue
#1351 #1510 New AddOcelot extensions to support custom ASP.NET MVC pipeline building via the IMvcCoreBuilder interface #1655
Merged
@raman-m
Copy link
Member

raman-m commented Sep 21, 2023 •
edited
Loading

@neetra @marciocrmendes
Hello, Oceloters!
Say Yahooo! 😉
Soon, you will be able to remove/add any DI services including Newtonsoft & TextJson.
Reopening!...🎉

@raman-m raman-m reopened this Sep 21, 2023
@raman-m raman-m mentioned this issue Sep 21, 2023
Merged
raman-m added a commit that referenced this issue Sep 23, 2023
@guoyongchang @raman-m
#1351 #1510 New AddOcelot extensions to support custom ASP.NET MVC pi…
b7976fc 
…peline building via the IMvcCoreBuilder interface (#1655)

* AddOcelot support custom mvc builder.

* Fix SA1503 : The opening and closing braces for a C# statement have been omitted.

* Fix SA1135 : A using directive is not qualified.

* Add AddDefaultAspNetServices method. Remove anonymous delegate.

* Make method names shorter

* add unit test for AddOcelotUsingBuilder

* Sort Usings

* Refactor integration test for the case with AddOcelotUsingBuilder

* Update OcelotBuilder.cs

* Update gettingstarted.rst

Fix target framework as net7.0

* Add "The AddOcelot method" paragraph

* Use correct heading levels for subsections

* Update configuration.rst

Use correct heading levels for (sub)sections

* Update configuration.rst

Readability improvements

* Incapsulate all system services to the AddDefaultAspNetServices method

* Add developer's XML-docs for OcelotBuilder and related extensions

* Create dependencyinjection.rst

* Update dependencyinjection.rst

Overview paragraph

* Update dependencyinjection.rst

"IServiceCollection extensions" paragraph.
"The OcelotBuilder class" paragraph.

* Update dependencyinjection.rst: Custom Builder paragraph

* Add Dependency Injection feature to the index of docs

* Update gettingstarted.rst: Add footnotes

* Correction of typo in English grammar

* Unit tests for AddOcelotUsingBuilder extension

* Improve readability of BDDfy scenarios in logs

* Update requestaggregation.rst. Add footnotes 

Mark down corrections

* Update tracing.rst: Add footnotes. Markdown text corrections

* Update qualityofservice.rst: Add footnotes

* Update administration.rst: Add footnotes. Markdown text corrections

* Update configuration.rst: Add footnotes. Text corrections

* IDE1006 Naming rule violation: These words must begin with upper case characters: should_*

---------

Co-authored-by: Raman Maksimchuk <dotnet044@gmail.com>
@raman-m raman-m added the merged Issue has been merged to dev and is waiting for the next release label Sep 23, 2023
@raman-m raman-m mentioned this issue Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neetra neetra

Labels
merged Issue has been merged to dev and is waiting for the next release proposal Proposal for a new functionality in Ocelot
Projects
None yet
Milestone
No milestone
3 participants
@raman-m @marciocrmendes @neetra